-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix various UI things in our paella integration (#1208)
This mainly does two things: - some buttons are moved into a settings menu to make the player appear less crammed on smaller screens (resolution, captions and video layout) - the control elements (which are also buttons) inside the videos (i.e. maximize video, switch sides etc.) are now less opaque and also smaller when their containers are below a certain width (currently 400px) Also: - the fullscreen button is now always on the rightmost side of the control bar (as you would expect) - the buttons for slide navigation were added to presentation videos Things mentioned in #1196 but missing here: - hide Firefox PiP button: -> this is not technically possible. Users need to disable it themselves in their browser. - hover color of vertical separation lines: -> I believe this needs to be fixed in paella-skins as any custom changes are always overwritten by that. Oh and I also noticed the thing @dagraf mentions in #1196 (comment): Open submenus are not fixed but move with the screen when scrolling up or down. This also needs to be fixed in paella. Closes #1196 Marked as draft bc I still need to figure out how to hide the settings menu when there are no menu items 🙈
- Loading branch information
Showing
5 changed files
with
90 additions
and
26 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters