Fix #34 - Fixed interface parameter - connected (l1up vs. up)

elad-bar · Oct 24, 2020 · b957408 · b957408
1 parent 9099a46
commit b957408
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+## 2020-10-24
+
+**Fixed bugs:**
+
+- Fixed interface parameter that should indicate whether an interface connected or not (l1up vs. up) [\#34](https://github.com/elad-bar/ha-edgeos/pull/34)
+
+
 ## 2020-09-17
 
 **Fixed bugs:**

diff --git a/custom_components/edgeos/helpers/const.py b/custom_components/edgeos/helpers/const.py
@@ -88,7 +88,8 @@
 TRUE_STR = "true"
 FALSE_STR = "false"
 
-LINK_UP = "up"
+LINK_ENABLED = "up"
+LINK_CONNECTED = "l1up"
 
 INTERFACES_STATS = "stats"
 
@@ -170,7 +171,8 @@
 SERVICE_SET_LEVEL = "set_level"
 
 INTERFACES_MAIN_MAP = {
-    LINK_UP: {ATTR_NAME: "Connected", ATTR_UNIT_OF_MEASUREMENT: "Connectivity"},
+    LINK_CONNECTED: {ATTR_NAME: "Connected", ATTR_UNIT_OF_MEASUREMENT: "Connectivity"},
+    LINK_ENABLED: {ATTR_NAME: "Enabled"},
     "speed": {ATTR_NAME: "Link Speed (Mbps)"},
     "duplex": {ATTR_NAME: "Duplex"},
     "mac": {ATTR_NAME: "MAC"},

diff --git a/custom_components/edgeos/managers/entity_manager.py b/custom_components/edgeos/managers/entity_manager.py
@@ -258,7 +258,7 @@ def create_interface_binary_sensor(self, key, data):
             data,
             self.config_data.monitored_interfaces,
             SENSOR_TYPE_INTERFACE,
-            LINK_UP,
+            LINK_CONNECTED,
             self.get_interface_attributes,
         )