-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly schedule working #28
Open
mRy0
wants to merge
3
commits into
ela-compil:master
Choose a base branch
from
mRy0:weekly_schedule_working
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.IO.BACnet.Serialize; | ||
using System.Linq; | ||
using System.Text; | ||
|
||
namespace System.IO.BACnet | ||
{ | ||
public struct BacnetDailySchedule : ASN1.IEncode, ASN1.IDecode | ||
{ | ||
public List<BacnetTimeValue> DaySchedule; | ||
|
||
|
||
|
||
public int Decode(byte[] buffer, int offset, uint count) | ||
{ | ||
int len = 0; | ||
DaySchedule = new List<BacnetTimeValue>(); | ||
//begin of daily sched | ||
if (ASN1.IS_OPENING_TAG(buffer[offset + len])) | ||
{ | ||
len++; | ||
//end of daily sched | ||
while (!ASN1.IS_CLOSING_TAG(buffer[offset + len]) ) | ||
{ | ||
len++; //ignore apptag time ? | ||
len += ASN1.decode_bacnet_time(buffer, offset + len, out DateTime time); | ||
|
||
|
||
var tagLen = ASN1.decode_tag_number_and_value(buffer, offset + len, out BacnetApplicationTags tagNumber, out uint lenValueType); | ||
BacnetValue value; | ||
if (tagLen > 0) | ||
{ | ||
len += tagLen; | ||
var decodeLen = ASN1.bacapp_decode_data(buffer, offset + len, offset + len + 1, tagNumber, lenValueType, out value); | ||
len += decodeLen; | ||
} | ||
else | ||
{ | ||
value = new BacnetValue(BacnetApplicationTags.BACNET_APPLICATION_TAG_NULL, null); | ||
} | ||
|
||
|
||
DaySchedule.Add(new BacnetTimeValue(new BacnetGenericTime(time, BacnetTimestampTags.TIME_STAMP_TIME), value)); | ||
|
||
} | ||
//closing tag | ||
len++; | ||
} | ||
|
||
return len; | ||
} | ||
|
||
public void Encode(EncodeBuffer buffer) | ||
{ | ||
ASN1.encode_opening_tag(buffer, 0); | ||
|
||
if (DaySchedule != null) | ||
{ | ||
foreach (var dayItem in DaySchedule) | ||
{ | ||
|
||
ASN1.encode_tag(buffer, (byte)BacnetApplicationTags.BACNET_APPLICATION_TAG_TIME, false, 4); | ||
ASN1.encode_bacnet_time(buffer, dayItem.Time.Time); | ||
|
||
ASN1.bacapp_encode_application_data(buffer, dayItem.Value); | ||
} | ||
} | ||
ASN1.encode_closing_tag(buffer, 0); | ||
} | ||
|
||
public override string ToString() | ||
{ | ||
return $"DaySchedule Len: {DaySchedule?.Count()}"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Text; | ||
|
||
namespace System.IO.BACnet | ||
{ | ||
public struct BacnetTimeValue | ||
{ | ||
public BacnetGenericTime Time; | ||
public BacnetValue Value; | ||
|
||
public BacnetTimeValue(BacnetGenericTime time, BacnetValue value) | ||
{ | ||
Time = time; | ||
Value = value; | ||
} | ||
|
||
public override string ToString() | ||
{ | ||
return $"{Time} = {Value}"; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code cosmetics. Please remove extra new lines you added in some places like this, max one empty line is ok. And when you see a line wrapping here, then it means it's a bit too long, please try to make it shorter.