trying out an iframe nav experiment, still a mess #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, so this is still a mess and has some really messed up layout (the iframe height is totally wrong) but it kinda works - the nav bar is on the side and not rendered into every page but when you click on links, the javascript pulls out the data-href attribute and updates the body, and you get a new page with a complete url and the back button works.
One bummer: the URL is kind of funky, and if you go to an element directly, you don't get the nav bar:
Maybe we could try using in a client-side router? This is the first one I found after googling very fast, there are probably others: https://github.com/krasimir/navigo
(Their main selling point is "if you want a router but don't want a full framework")