Simplify the Eq/Ord instances for FT
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While slightly more verbose, the new instance contexts avoid the need for overlapping instances or `FlexibleContexts`.
|
Awesome, it's sufficient for the purposes of haskell/core-libraries-committee#10 |
|
I've uploaded |
|
I think this could be further simplified? |
|
How so? |
|
I opened #217 for this. If it doesn't block haskell/core-libraries-committee#10 fine to just worry about later :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While slightly more verbose, the new instance contexts avoid the need for overlapping instances or
FlexibleContexts.This should also allow
freeto compile with the changes in haskell/core-libraries-committee#10. cc @Bodigrim