Fix #36 + add many useful instances #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `shell.nix` file is locally useful for Nix-aided development.
Fixed `Cofree`'s `Apply` instance, made the `Monad` instance dependent on `Plus` instead of `Alternative`, removed incorrect `MonadZip` instance. The `Plus`-based `Monad` instance allows using `Cofree` as a reentry monad by allowing `Map`-like structures to record named reentry points.
`CofreeT` is a very useful monad transformer for actions that can set named reentry labels. This can be used, for example, for continuation-based web frameworks, which is the motivation behind these instances.
|
Two major issues here: First, I've generally tried to keep things so that instances for But, even if that wasn't a factor, there is a rather glaring oversight to be corrected here! (In my code, not yours.) The |
|
Issue #36 talks about the problematic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits for explanations.