Added option for HTML5 datalist input #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagan-bansal
commented
Oct 4, 2019
| inputType = inputSetting.type.toLowerCase(); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Just replaced tabs with space.
gagan-bansal
commented
Oct 4, 2019
| if (typeof inputSetting.options !== 'undefined' && typeof inputSetting.options.icon !== 'undefined') { | ||
| icon = inputSetting.options.icon; | ||
| } | ||
| var self = jQuery('.datepick').datepicker( |
There was a problem hiding this comment.
Just replaced tab with space.
gagan-bansal
commented
Oct 4, 2019
| },100); | ||
| break; | ||
| },100); | ||
| break; |
There was a problem hiding this comment.
Just replaced tab with space.
gagan-bansal
commented
Oct 4, 2019
| default: // text input | ||
| input.html = startWrapperHtml + "<input id='ejbeatycelledit' class='" + inputCss + "' onfocusout='$(this).updateEditableCell(this)' value='" + oldValue + "'></input>" + endWrapperHtml; | ||
| case "number-confirm" : | ||
| input.html = startWrapperHtml + "<input id='ejbeatycelledit' type='number' class='" + inputCss + "' value='"+oldValue+"'" + (listenToKeys ? " onkeyup='if(event.keyCode==13) {$(this).updateEditableCell(this);} else if (event.keyCode===27) {$(this).cancelEditableCell(this);}'" : "") + "></input> <a href='javascript:void(0);' class='" + confirmCss + "' onclick='$(this).updateEditableCell(this)'>Confirm</a> <a href='javascript:void(0);' class='" + cancelCss + "' onclick='$(this).cancelEditableCell(this)'>Cancel</a>" + endWrapperHtml; |
|
Should I squash all the three commits? |
|
Squashed all my commits. |
|
HI @ejbeaty, Can you please check if this can me merged. Gagan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also added a column city in advance.html to showcase the type
datalist.