Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to test using local CF build #5

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Add option to test using local CF build #5

merged 7 commits into from
Apr 5, 2024

Conversation

rohan-shettyy
Copy link
Collaborator

No description provided.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up!

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gradle/libs.versions.toml Outdated Show resolved Hide resolved
build.gradle Outdated
def cfHome = String.valueOf(System.getenv('CHECKERFRAMEWORK'))
dependencies {
testImplementation files(cfHome + '/checker/dist/checker.jar')
testImplementation files(cfHome + '/framework-test/build/libs/framework-test-3.42.0-eisop3-SNAPSHOT.jar')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do this without hard-coding the version? It would be rather annoying to have to update this string for local testing.
If there is no simple way here, let's make a eisop PR that also creates a /checker/dist/framework-test.jar file.

Copy link
Collaborator Author

@rohan-shettyy rohan-shettyy Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the dependency on this framework-test jar doesn't do anything in the local case, but the dependency on framework-test in general is required to recognize all symbols.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wmdietl wmdietl merged commit 0513ffc into main Apr 5, 2024
2 checks passed
@wmdietl wmdietl deleted the local-cf branch April 5, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants