Basic CI and gradle setup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
approved these changes
Mar 22, 2024
gradle/libs.versions.toml
Outdated
| junitVer = "5.9.1" | ||
|
|
||
| [libraries] | ||
| junit = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junitVer" } |
There was a problem hiding this comment.
Suggested change
| junit = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junitVer" } | |
| junit = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junitVer" } |
There was a problem hiding this comment.
I can't commit this suggestion... I'm trying to get rid of the red warning sign at the end of the file, by adding a newline. It shows a diff, but doesn't let me commit it...
settings.gradle
Outdated
Comment on lines
1
to
7
| /* | ||
| * This file was generated by the Gradle 'init' task. | ||
| * | ||
| * The settings file is used to specify which projects to include in your build. | ||
| * For more detailed information on multi-project builds, please refer to https://docs.gradle.org/8.6/userguide/multi_project_builds.html in the Gradle documentation. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Suggested change
| /* | |
| * This file was generated by the Gradle 'init' task. | |
| * | |
| * The settings file is used to specify which projects to include in your build. | |
| * For more detailed information on multi-project builds, please refer to https://docs.gradle.org/8.6/userguide/multi_project_builds.html in the Gradle documentation. | |
| */ |
|
Once you fixed the two small suggestions, please squash and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.