Skip to content

Commit

Permalink
added first puzzle for 0pdd bot
Browse files Browse the repository at this point in the history
  • Loading branch information
eimfach committed Oct 28, 2019
1 parent 4a4bd3a commit 7827cb5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/elm/Parsers.elm
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ parseInt =
]


{-| Used to Parse a float in a chain of other parsers. Supporting `,` _and_ `.` decimal separators.
@todo Parsing Float Strings with additional thousands separators is not supported. The parsing will fail in this scenario.
{-| @todo #1 Used to Parse a float in a chain of other parsers. Supporting `,` _and_ `.` decimal separators.
Parsing Float Strings with additional thousands separators is not supported. The parsing will fail in this scenario.
Consider using `Parser.loop` and `Parser.oneOf`. Also I think it should test if the created number is supported by the js runtime.
There is an elm lib to do this. Maybe it is easy to implement it by yourself, and the lib is not needed. Also, should mixed separator 'types' be possible ?
or could it cause a performance issue ? Right now it supports mixed decimal separators unsing `Parser.oneOf`
or could it cause a performance issue ? Right now it supports mixed decimal separators using `Parser.oneOf`
-}
parseChainFloat : Parser.Parser ( String, String, String )
parseChainFloat =
Expand Down

1 comment on commit 7827cb5

@0pdd
Copy link

@0pdd 0pdd commented on 7827cb5 Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-94a45435 discovered in src/elm/Parsers.elm and submitted as #1. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.