Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for exchange server/client #93

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Add integration tests for exchange server/client #93

merged 5 commits into from
Oct 6, 2023

Conversation

fl0rek
Copy link
Member

@fl0rek fl0rek commented Oct 4, 2023

Grouped by the setup:

  • simple client header, similar to existing unittests, but without mocking sending/receiving requests
  • multiple peers to see whether head choice algorithm works correctly
  • server with prepared invalid store to test client validation

@fl0rek fl0rek requested review from oblique and zvolin October 4, 2023 16:16
zvolin
zvolin reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, left a few comments / discussions

node/src/store.rs Outdated Show resolved Hide resolved
node/tests/node.rs Outdated Show resolved Hide resolved
node/tests/node.rs Outdated Show resolved Hide resolved
node/tests/node.rs Outdated Show resolved Hide resolved
node/tests/node.rs Outdated Show resolved Hide resolved
node/tests/node.rs Show resolved Hide resolved
oblique
oblique approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

node/tests/exchange.rs Show resolved Hide resolved
zvolin
zvolin approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zvolin zvolin force-pushed the chore/exchange-server-client-integration-tests0 branch from 31a01fb to 86a70ff Compare October 6, 2023 10:55
@zvolin zvolin enabled auto-merge (squash) October 6, 2023 10:57
fl0rek and others added 5 commits October 6, 2023 13:38
@fl0rek
Add integration tests for exchange server/client
4ffe204 
Signed-off-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek
better names, additional tests
9354411 
Signed-off-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek @zvolin
Update node/tests/node.rs
215d52e 
Co-authored-by: Maciej Zwoliński <[email protected]>
Signed-off-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek
split exchange tests, cleanup names and includes
684ab08 
Signed-off-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek
unconditional clone
eadb5f0 
Signed-off-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek fl0rek force-pushed the chore/exchange-server-client-integration-tests0 branch from 86a70ff to eadb5f0 Compare October 6, 2023 11:38
@zvolin zvolin merged commit 3ec12e2 into eigerco:main Oct 6, 2023
0 of 4 checks passed
@oblique oblique mentioned this pull request Oct 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Closed
@zvolin zvolin mentioned this pull request Jan 12, 2024
Merged
@fl0rek fl0rek deleted the chore/exchange-server-client-integration-tests0 branch July 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@oblique oblique oblique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl0rek @oblique @zvolin