Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto,types,rpc)!: celestia node v0.20.4 upgrade #469

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Nov 28, 2024

No description provided.

@zvolin zvolin changed the title feat(proto,types,rpc)!: celestia node v0.20.2 upgrade feat(proto,types,rpc)!: celestia node v0.20.4 upgrade Nov 28, 2024
@zvolin
Copy link
Member Author

zvolin commented Nov 28, 2024

failures come from the fact that block time in our CI setup increased from 1s to over 4s

@zvolin zvolin marked this pull request as ready for review November 28, 2024 14:00
@zvolin
Copy link
Member Author

zvolin commented Nov 28, 2024

timeout_commit is now hardcoded per app version and we would need to patch the validator to lower it. This makes our rpc and shwap tests 4.2 times longer (because timeout commit is 4.2s)

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rpc/src/share.rs Outdated Show resolved Hide resolved
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique oblique enabled auto-merge (squash) November 29, 2024 09:38
@zvolin zvolin disabled auto-merge November 29, 2024 11:00
@zvolin zvolin requested review from fl0rek and oblique November 29, 2024 11:00
@zvolin zvolin force-pushed the feat/celestia-node-v0.20.2-update branch from b792e53 to dd86973 Compare November 29, 2024 11:01
@fl0rek fl0rek merged commit 87fe149 into eigerco:main Nov 29, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Nov 29, 2024
@zvolin zvolin deleted the feat/celestia-node-v0.20.2-update branch November 29, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants