feat: unused deps workflow #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! @zvolin Do we want this once a day or as a CI job? I think it is safe to do it once a day. What do you think? |
|
I think I'd prefer this on PRs job, as it's where such unused deps can be introduced and the action could be then taken immediately. Once a day would be more suited for things like cargo audit. Nevertheless thanks for the contrib @Evalir and I'm also okay with having this periodic now |
|
happy to change it to run per-pr—it's a quick one |
|
@Evalir Yes please :) |
|
done :) @oblique |
zvolin
force-pushed
the
evalir/add-unused-deps-workflow
branch
from
680f657 to
87261ac
Compare
fl0rek
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
Adds an unused deps workflow that will trigger at UTC 00:00 each day, or when the workflow is dispatched manually, using cargo udeps.