Skip to content

Commit

Permalink
Update proto/vendor/README.md
Browse files Browse the repository at this point in the history
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
  • Loading branch information
oblique and fl0rek authored Dec 4, 2024
1 parent bf79497 commit 78e28c8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions proto/vendor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ the `tendermint` one. For example in `abci/types.proto` we changed `RequestEcho`
([link 1](https://github.com/eigerco/lumina/blob/82c51f6ac88fd3662a0f91a0cf19a717986e3470/proto/vendor/tendermint-celestia-mods/abci/types.proto#L21),
[link 2](https://github.com/eigerco/lumina/blob/82c51f6ac88fd3662a0f91a0cf19a717986e3470/proto/vendor/tendermint-celestia-mods/abci/types.proto#L148)).

If the message type of the field is redefined in `tendermint-celestia-mods` then the one from the
modifications should be used
If a message type of the field is redefined in `tendermint-celestia-mods` then only the modified one should be used.
([link](https://github.com/oblique/lumina/blob/82c51f6ac88fd3662a0f91a0cf19a717986e3470/proto/vendor/tendermint-celestia-mods/abci/types.proto#L70-L73)).
Keep in mind that if the type exists in the same file, then full path is not needed.

Expand Down

0 comments on commit 78e28c8

Please sign in to comment.