Fix unit tests

firebird-ng/src/app/services/server-config.service.spec.ts

@@ -1,9 +1,8 @@
-import { TestBed } from '@angular/core/testing';
+import { TestBed, waitForAsync } from '@angular/core/testing';
 import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
 import { ServerConfigService } from './server-config.service';
-import * as jsoncParser from 'jsonc-parser';
 
-describe('FirebirdConfigService', () => {
+describe('ServerConfigService', () => {
   let service: ServerConfigService;
   let httpMock: HttpTestingController;
 
@@ -19,21 +18,25 @@ describe('FirebirdConfigService', () => {
   afterEach(() => {
     httpMock.verify(); // Ensure that no requests are outstanding.
   });
-  //
-  it('should fetch and parse JSONC data correctly', () => {
-    const dummyConfig = { apiBaseUrl: "http://localhost:5454" };
-    const jsoncData = '{ "key": "value" // comment }';
+
+  it('should fetch and parse JSONC data correctly', async () => {
+    const jsoncData = '{ "apiBaseUrl": "http://localhost:5454", "logLevel": "info" }';
+
+    // Call loadConfig()
+    const loadPromise = service.loadConfig();
 
     // Set up the HttpTestingController
     const req = httpMock.expectOne(service['configUrl']);
     expect(req.request.method).toBe('GET');
-    req.flush('{ "apiBaseUrl": "http://localhost:5454", "logLevel": "info" }'); // Mock the HTTP response
 
-    service.loadConfig().then(()=>{
-      expect(service.config.apiBaseUrl).toBe("http://localhost:5454");
-    });
+    // Mock the HTTP response
+    req.flush(jsoncData);
 
+    // Wait for loadConfig() to complete
+    await loadPromise;
+
+    // Verify the config
+    expect(service.config.apiBaseUrl).toBe("http://localhost:5454");
+    expect(service.config.logLevel).toBe("info");
   });
 });
-
-

firebird-ng/src/app/services/user-config.service.spec.ts

@@ -26,8 +26,8 @@ describe('UrlService', () => {
 
     const mockServerConfigService = {
       config: {
-        servedByPyrobird: false,
-        apiBaseUrl: 'http:/localhost:4545'
+        servedByPyrobird: true,
+        apiBaseUrl: 'http://localhost:5454'
       }
     };
 
@@ -68,8 +68,13 @@ describe('UrlService', () => {
 
     it('should handle relative URL without protocol when backend is not available (Case 1.2)', () => {
       // Ensure backend is not available
+      serverConfigService.config.servedByPyrobird = false;
       userConfigService.localServerUseApi.subject.next(false);
 
+      // Manually trigger the service to update its config
+      (service as any).updateServerConfig();
+
+
       const inputUrl = '/path/to/file.root';
       const resolvedUrl = service.resolveDownloadUrl(inputUrl);
       expect(resolvedUrl).toBe(inputUrl);
@@ -120,8 +125,14 @@ describe('UrlService', () => {
 
     it('should return input URL when backend is not available', () => {
       // Ensure backend is not available
+      // Ensure backend is not available
+      serverConfigService.config.servedByPyrobird = false;
       userConfigService.localServerUseApi.subject.next(false);
 
+      // Manually trigger the service to update its config
+      (service as any).updateServerConfig();
+
+
       const inputUrl = 'https://example.com/file.root';
       const fileType = 'edm4eic';
       const entries = 'all';