Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking_performances: adapt to upcoming naming change for truth/real seeding collection names #50

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 2, 2024

Briefly, what does this PR introduce?

Should we go ahead with eic/EICrecon#1605, this will be needed to keep the benchmark working.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@Simple-Shyam
Copy link
Contributor

Thanks. It looks fine but there are some errors. I would also like to see the results in the test mode on small samples because I want to see the result after the new update of geometry (there were changed in MPGD geometry) just to check the consistency of the results.

@wdconinc
Copy link
Contributor

It's dead jim, https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/3778287

@veprbl veprbl merged commit 6f1fa81 into master Sep 12, 2024
2 checks passed
@veprbl veprbl deleted the pr/collection_names_forward_compat branch September 12, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants