Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking_performances: Adjust axis extent #31

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

Simple-Shyam
Copy link
Contributor

Briefly, what does this PR introduce?

Minor fix in the code and range on the X axis is modified.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • [ x] Other: __
  • minor fix in the code

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [ x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl
Copy link
Member

veprbl commented Jul 6, 2024

Just, FYI, the eicweb service is down this weekend, wel'll be able to test it no earlier than Monday.

@veprbl veprbl changed the title Trackingperformances tracking_performances: Adjust axis extent Jul 6, 2024
@Simple-Shyam
Copy link
Contributor Author

Just, FYI, the eicweb service is down this weekend, wel'll be able to test it no earlier than Monday.

Thank you it's fine for me.

@Simple-Shyam
Copy link
Contributor Author

Just, FYI, the eicweb service is down this weekend, wel'll be able to test it no earlier than Monday.

Thank you it's fine for me.

Is it finished?

@veprbl
Copy link
Member

veprbl commented Jul 9, 2024

I've restarted the "Mirror and Trigger EICweb" to re-trigger the eicweb job. This has picked up now. Let's see.

@Simple-Shyam
Copy link
Contributor Author

Thanks. I was thinking once it's done then I can mention in Thursday's tracking meeting and point to the artifacts.

@veprbl
Copy link
Member

veprbl commented Jul 9, 2024

(We need to re-run with latest changes like #29, as your local branch wasn't including it.)

@veprbl
Copy link
Member

veprbl commented Jul 9, 2024

It's ready btw. You can navigate "Show all checks", then "Details" for "eicweb/detector_benchmarks", then locate "collect_results:tracking_performance", open it, then "Browse" button on "Job artifacts" panel.

@Simple-Shyam Simple-Shyam merged commit 39a24e2 into master Jul 10, 2024
2 checks passed
@Simple-Shyam Simple-Shyam deleted the trackingperformances branch July 10, 2024 03:16
@Simple-Shyam
Copy link
Contributor Author

Thanks Dmitry, Now you can see the results for truth/real seeding is almost same except low momentum as I expect.
In the plot linked below at 0.5 GeV/c, there is a point with a 0 value for this, I need to check 1D Gaussian plot (What happened with Gaussian? ) once we store 1D debug plots directory.
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/3505085/artifacts/file/results/tracking_performances/mom_resol_-3.5_eta_-2.5.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants