Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks/barrel_ecal: orchestrate using a Snakefile #1

Merged
merged 6 commits into from
Dec 31, 2023
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 12, 2023

Briefly, what does this PR introduce?

This is https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/merge_requests/156, now contributed on GitHub

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@wdconinc wdconinc self-requested a review December 22, 2023 20:50
Copy link
Member Author

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use workflow.source_path to support out-of-tree builds

benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
benchmarks/barrel_ecal/Snakefile Outdated Show resolved Hide resolved
@veprbl veprbl merged commit fbf24b4 into master Dec 31, 2023
4 checks passed
@veprbl veprbl deleted the pr/Snakemake branch December 31, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant