Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased w0 parameter in cluster CoG for the ZDC #1617

Merged
merged 3 commits into from
Sep 17, 2024
Merged

increased w0 parameter in cluster CoG for the ZDC #1617

merged 3 commits into from
Sep 17, 2024

Conversation

sebouh137
Copy link
Contributor

@sebouh137 sebouh137 commented Sep 16, 2024

increases the w0 parameter in the ZDC cluster reconstruction CoG so that the subcell with the largest energy does not dominate the position reconstruction too much. Without this fix, the positions of the clusters are strongly pulled towards the subcell with the most energy, causing an unwanted pattern in the reconstructed cluster position.

Briefly, what does this PR introduce?

Increase the w0 parameter in the ZDC

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: parameter tweaking

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes. modifies the paramters of the cluster position reconstruction

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction labels Sep 16, 2024
@sebouh137 sebouh137 changed the title increased w0 parameter in order to alleviate the 'lotus effect' in th… increased w0 parameter in cluster CoG for the ZDC Sep 16, 2024
@sebouh137 sebouh137 marked this pull request as ready for review September 16, 2024 21:01
Copy link

sonarcloud bot commented Sep 17, 2024

@sebouh137 sebouh137 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit f833c1b Sep 17, 2024
85 of 86 checks passed
@sebouh137 sebouh137 deleted the adjust_w0 branch September 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants