IterativeVertexFinder: fill vertex-to-particle relation #1576
Conversation
- added association for ReconstructionParticles to output vertices
for more information, see https://pre-commit.ci
Capybara summary for PR 1576 |
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
|
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
|
|
veprbl
changed the title
|
Hi Woulter and Dmitry, Are these anything you would like to comment before merging this PR? The requested change Woulter brought up, I believe, is addressed in the later commits. Would appreciate if you can take a review to see whether we can proceed. Thanks /xin |
|
I don't understand why this hasn't merged over the weekend. Maybe we needed to have and approval form @wdconinc or dismiss his "1 change requested" review. |
There was a problem hiding this comment.
The 'request changes' is always sticky and requires the same person who requested changes to give explicit approval. In this case, I requested changes since we needed to use the podio collection instead of std::vector. That's been done now, so I approve.
One more comment though on a magic number that should be a configuration variable (best) or defined as a ratio of another dimensionful quantity. The reconstruction should not care whether we work in dd4hep units or, for some reason, another unit system.
|
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?