Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add algorithms_test/calorimetry_CalorimeterClusterRecoCoG.cc #1279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add algorithms_test/calorimetry_CalorimeterClusterRecoCoG.cc #1279

wants to merge 2 commits into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 5, 2024 •
edited
Loading

Things to be tested:

  • Weight functions/Multiple hits
  • Eta bounds (not clear what case this is for)
  • Cluster shapes
  • Null pointers passed for sim hits (algorithm segfaults despite interface suggesting that it should accept those values)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Capybara summary for PR 1279

@rahmans1
Copy link
Contributor

rahmans1 commented Feb 7, 2024

@veprbl Should this be in February release?

@veprbl
Copy link
Member Author

veprbl commented Feb 7, 2024

Not relevant to campaigns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: calorimetry relates to calorimetry topic: infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veprbl @rahmans1