Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertex output missing associated ReconstructedParticles #1575

Open
starsdong opened this issue Aug 16, 2024 · 0 comments
Open

Vertex output missing associated ReconstructedParticles #1575

starsdong opened this issue Aug 16, 2024 · 0 comments

Comments

@starsdong
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As stated in the title

Describe the solution you'd like
Add ReconstructedParticle as input to IVF. The links between ReconstructedParticles to Acts vertices are not explicit. Will compare trajectory parameters to create the link

Describe alternatives you've considered

Additional context
@starsdong starsdong mentioned this issue Aug 23, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@starsdong @pre-commit-ci @veprbl
IterativeVertexFinder: fill vertex-to-particle relation (#1576)
816a8da 
### Briefly, what does this PR introduce?
- added association for ReconstructionParticles to output vertices

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [X] New feature (issue #1575)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [X] Tests for the changes have been added
- [X] Documentation has been added / updated
- [X] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?
- ReconstructedParticle association added to the default output
CKFCentralVertices

---------

Co-authored-by: Xin Dong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Xin Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starsdong