fix(practs): bump practs to latest best

.eslintrc.js

@@ -43,5 +43,6 @@ module.exports = {
     '@typescript-eslint/lines-between-class-members': 'off',
     'no-return-await': 'off', // this does not help anything and actually leads to bugs if we subsequently wrap the return in a try catch without remembering to _then_ add await
     '@typescript-eslint/return-await': 'off',
+    '@typescript-eslint/no-unsafe-declaration-merging': 'off',
   },
 };

.gitattributes

@@ -0,0 +1,2 @@
+# exclude package-lock from git diff; https://stackoverflow.com/a/72834452/3068233
+package-lock.json -diff

.github/workflows/.publish-npm.yml

@@ -19,7 +19,6 @@ jobs:
         with:
           registry-url: 'https://registry.npmjs.org/'
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: node-modules cache get
         uses: actions/cache/restore@v3
@@ -36,6 +35,6 @@ jobs:
         run: npm run build
 
       - name: publish
-        run: npm publish
+        run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.npm-auth-token }}

.github/workflows/.test.yml

@@ -30,7 +30,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: node-modules cache get
         uses: actions/cache/restore@v3
@@ -64,7 +63,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -86,7 +84,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -108,7 +105,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -130,7 +126,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -152,7 +147,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -161,7 +155,7 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
 
       - name: test:unit
-        run: npm run test:unit
+        run: THOROUGH=true npm run test:unit
 
   test-integration:
     runs-on: ubuntu-latest
@@ -174,7 +168,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3
@@ -202,7 +195,7 @@ jobs:
         run: npm run provision:integration-test-db --if-present
 
       - name: test:integration
-        run: npm run test:integration
+        run: THOROUGH=true npm run test:integration
 
   test-acceptance-locally:
     runs-on: ubuntu-latest
@@ -215,7 +208,6 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
-          cache: 'npm'
 
       - name: get node-modules from cache
         uses: actions/cache/restore@v3

.github/workflows/review.yml

@@ -0,0 +1,26 @@
+name: review
+
+on:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+permissions:
+  pull-requests: read
+
+jobs:
+  pullreq-title:
+    runs-on: ubuntu-latest
+    steps:
+      - name: test:pullreq:title
+        uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          # https://github.com/commitizen/conventional-commit-types
+          types: |
+            fix
+            feat
+            chore

.gitignore

@@ -5,6 +5,7 @@
 .serverless
 .terraform
 .terraform.lock
+.yalc
 coverage
 dist
 node_modules

.husky/check.lockfile.sh

@@ -6,5 +6,5 @@ changed () {
 }
 
 if changed 'package-lock.json'; then
-  echo "📦 package-lock.json changed. Run npm install to update your locally installed dependencies."
+  echo "📦 package-lock.json changed. Run 'npm install' to update your locally installed dependencies."
 fi

.husky/check.yalc.sh

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+# https://github.com/wclr/yalc
+if [ "$(npx yalc check)" ]; then
+    echo "✋ package.json has yalc references. Run 'npx yalc remove --all' to remove these local testing references."
+fi
+

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+. "$(dirname -- "$0")/check.yalc.sh"

.nvmrc

@@ -1 +1 @@
-lts/*
+v20.12.2

jest.acceptance.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,

jest.integration.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,

jest.integration.env.ts

@@ -12,4 +12,4 @@ if (
   (process.env.NODE_ENV !== 'test' || process.env.STAGE) &&
   process.env.I_KNOW_WHAT_IM_DOING !== 'true'
 )
-  throw new Error(`unit-test is not targeting stage 'test'`);
+  throw new Error(`integration.test is not targeting stage 'test'`);

jest.unit.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,