Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract egraph-serialize features #466

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

DaniPopes
Copy link
Contributor

egraph-serialize's "serde" and "graphviz" features are not used in the library but are always enabled. Disable them by default and extract them into our own features that just delegate to egraph-serialize to preserve the functionality.

This is a breaking change for library users that disable default features.

@DaniPopes DaniPopes requested a review from a team as a code owner November 10, 2024 15:17
@DaniPopes DaniPopes requested review from ezrosent and removed request for a team November 10, 2024 15:17
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #466 will not alter performance

Comparing DaniPopes:serialize-features (6a830c5) with main (2c8d947)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me, thanks for the warning on the possible downstream breakage.

@saulshanabrook saulshanabrook merged commit 135327b into egraphs-good:main Nov 11, 2024
5 checks passed
@DaniPopes DaniPopes deleted the serialize-features branch November 13, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants