Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'serde-1' attribute #465

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Nov 10, 2024

The feature "serde-1" doesn't exist.

The other change is a warning issued on a more recent rust version:

warning: elided lifetime has a name
  --> src/function/index.rs:65:40
   |
62 |     pub(crate) fn to_canonicalize<'a>(
   |                                   -- lifetime `'a` declared here
...
65 |     ) -> impl Iterator<Item = usize> + '_ {
   |                                        ^^ this elided lifetime gets resolved as `'a`
   |
   = note: `#[warn(elided_named_lifetimes)]` on by default

@DaniPopes DaniPopes requested a review from a team as a code owner November 10, 2024 15:10
@DaniPopes DaniPopes requested review from ezrosent and removed request for a team November 10, 2024 15:10
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #465 will not alter performance

Comparing DaniPopes:unused-serde1 (d723300) with main (2c8d947)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed this as well. I guess maybe originally there was some hope to make the union find serializable. I think at this point that has been superseded by the e-graph serialization format.

Thank you!

@saulshanabrook saulshanabrook merged commit ae271b3 into egraphs-good:main Nov 11, 2024
5 checks passed
@DaniPopes DaniPopes deleted the unused-serde1 branch November 13, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants