Speed up local make test runs
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Fischman
requested review from
mwillsey and
saulshanabrook
and removed request for
a team and
mwillsey
CodSpeed Performance ReportMerging #458 will not alter performanceComparing Summary
|
saulshanabrook
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Thank you for this!
I did some testing and on main when I run make test and then add a newline somewhere, and re-run it, the time to compile is 1m 56s Then with this PR the incremental time is 7s! Compared with the time to actually run tests and doctests after they are compiled which is only 8s on my machine.
It looks like our cache action will set this env variable already but it seems like no harm in making it explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables incremental builds for release mode to speed up hot runs of
make test. It also turns off incremental builds in CI, following the advice of this blog post.