Uat v2 #558
Uat v2 #558
Conversation
gurpreetsinghkhanna
requested review from
ramakrishnaippili-eGov,
elzanmathew-eGov and
poonam1512
as code owners
WalkthroughThe recent updates enhance the CI/CD process through a modular Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files ignored due to path filters (180)
build/build-config.ymlis excluded by:!**/*.ymlconfigs/egov-dss-dashboards/dashboard-analytics/ChartApiConfig.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-analytics/MasterDashboardConfig.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-analytics/RoleDashboardMappingsConf.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-analytics/TenantCodeNameMappings.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/CollectionDomainConfig.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/DomainConfig.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/EnhanceDomainConfig.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/TopicContextConfiguration.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_collection_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_firenoc_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_mcollect_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_pt_enhance_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_pt_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_sw.one_time_fee_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_sw_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_tl_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_ws.one_time_fee_v1.jsonis excluded by:!**/*.jsonconfigs/egov-dss-dashboards/dashboard-ingest/transform_ws_v1.jsonis excluded by:!**/*.jsonconfigs/egov-indexer/billingservices-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/chatbot-telemetry-v2.yamlis excluded by:!**/*.yamlconfigs/egov-indexer/chatbot-telemetry.yamlis excluded by:!**/*.yamlconfigs/egov-indexer/covid-chatbot-telemetry.yamlis excluded by:!**/*.yamlconfigs/egov-indexer/egov-bpa-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/error-queue.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/finance-rolloutadoption-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/payment-indexer-migration.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/payment-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/property-services-migration-temp.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/property-services-migration.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/property-services.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/rainmaker-bpastakeholder-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/rainmaker-firenoc-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/rainmaker-pgr-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/rainmaker-tl-indexer.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/sewerage-service.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/water-service.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/water-services-meter.ymlis excluded by:!**/*.ymlconfigs/egov-indexer/whatsapp-adoption-data.yamlis excluded by:!**/*.yamlconfigs/egov-persister/assessment-persister-migration-temp.ymlis excluded by:!**/*.ymlconfigs/egov-persister/assessment-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/billing-services-persist.ymlis excluded by:!**/*.ymlconfigs/egov-persister/chatbot.ymlis excluded by:!**/*.ymlconfigs/egov-persister/collection-migration-count.ymlis excluded by:!**/*.ymlconfigs/egov-persister/collection-migration-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/echallan.ymlis excluded by:!**/*.ymlconfigs/egov-persister/egf-bill.yamlis excluded by:!**/*.yamlconfigs/egov-persister/egov-user-event-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/egov-workflow-v2-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/firenoc-calculator-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/firenoc_persiter.yamlis excluded by:!**/*.yamlconfigs/egov-persister/hrms-employee-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/migration-batch-count-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/pdf-filestoreid-update.ymlis excluded by:!**/*.ymlconfigs/egov-persister/pdf-generator.ymlis excluded by:!**/*.ymlconfigs/egov-persister/pgr.ymlis excluded by:!**/*.ymlconfigs/egov-persister/property-services-migration-temp-config.ymlis excluded by:!**/*.ymlconfigs/egov-persister/property-services-registry.ymlis excluded by:!**/*.ymlconfigs/egov-persister/property-services.ymlis excluded by:!**/*.ymlconfigs/egov-persister/pt-mutation-calculator-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/pt-persist.ymlis excluded by:!**/*.ymlconfigs/egov-persister/sewerage-bill-scheduler.ymlis excluded by:!**/*.ymlconfigs/egov-persister/sewerage-persist.ymlis excluded by:!**/*.ymlconfigs/egov-persister/tradelicense-persister.ymlis excluded by:!**/*.ymlconfigs/egov-persister/tradelicense.ymlis excluded by:!**/*.ymlconfigs/egov-persister/water-bill-scheduler.ymlis excluded by:!**/*.ymlconfigs/egov-persister/water-meter.ymlis excluded by:!**/*.ymlconfigs/egov-persister/water-persist.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/PTDemandBasedSearcher.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/bill-genie.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/localitySearcher.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/propertyopensearch.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/rainmaker-pgr-v2-searcher.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/rainmaker-pt-customsearch-punjab.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/rainmaker-pt-gissearch.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/rainmaker-tl.ymlis excluded by:!**/*.ymlconfigs/egov-searcher/weekly-impact-emailer-searcher.ymlis excluded by:!**/*.ymlconfigs/egov-zuul/post-hook.jsonis excluded by:!**/*.jsonconfigs/monitoring-dashboards/kube-cluster-dashboard.jsonis excluded by:!**/*.jsonconfigs/monitoring-dashboards/nginx-ingress-dashboard.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/bill-amendment-note.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/bill-amendment.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/bpa-revocation.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/buildingpermit-low.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/buildingpermit.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/consolidated-pdf1.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/consolidated-pdf2.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/consolidatedbill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/consolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/consolidatedreceiptold.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/firenoc-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/firenocreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/mcollect-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/mcollect-challan.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/misc-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/passvehicle-certificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/property-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/property-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/pt-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ptmutationcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/sewerage-bill-amendment-note.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/sw-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/testconsolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/testlocalconsolidatedbill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/testlocalconsolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tl-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tlapplication.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tlcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tlrenewalcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tradelicense-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/tradelicense-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-applicationsewerage.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-applicationwater.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-consolidatedacknowlegment.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-consolidatedsewerageconnection.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-estimationnotice.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-onetime-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/data-config/ws-sanctionletter.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/bill-amendment-note.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/bill-amendment.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/bpa-revocation.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/buildingpermit-low.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/buildingpermit.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/consolidated-pdf1.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/consolidated-pdf2.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/consolidatedbill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/consolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/consolidatedreceiptold.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/firenoc-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/firenocreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/mcollect-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/mcollect-challan.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/misc-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/passvehicle-certificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/property-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/property-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/pt-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ptmutationcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/sewerage-bill-amendment-note.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/sw-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/testconsolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/testlocalconsolidatedbill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/testlocalconsolidatedreceipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tl-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tlapplication.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tlcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tlrenewalcertificate.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tradelicense-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/tradelicense-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-applicationsewerage.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-applicationwater.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-bill.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-consolidatedacknowlegment.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-consolidatedsewerageconnection.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-estimationnotice.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-onetime-receipt.jsonis excluded by:!**/*.jsonconfigs/pdf-service/format-config/ws-sanctionletter.jsonis excluded by:!**/*.jsonconfigs/reports/configs/asset-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/citizen-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/common-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/e-pass-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/finance-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/hrms-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/inventoryReport.ymlis excluded by:!**/*.ymlconfigs/reports/configs/lcms-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/pgr-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/pt-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/rainmaker-common-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/rainmaker-noc-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/rainmaker-pgr-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/rainmaker-pt-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/rainmaker-tl-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/swm-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/tl-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/uc-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/works-reports.ymlis excluded by:!**/*.ymlconfigs/reports/configs/ws-reports.ymlis excluded by:!**/*.ymlrainmaker-custom-service/package.jsonis excluded by:!**/*.jsonrainmaker-custom-service/yarn.lockis excluded by:!**/*.lock
Files selected for processing (4)
- Jenkinsfile (1 hunks)
- build/maven/Dockerfile (1 hunks)
- build/maven/start.sh (1 hunks)
- configs/egov-dss-dashboards/.project (1 hunks)
Files skipped from review due to trivial changes (1)
- configs/egov-dss-dashboards/.project
Additional comments: 2
Jenkinsfile (1)
- 1-3: The changes in the Jenkinsfile, replacing previous logic with a call to
buildPipeline, streamline the build process. Ensure that thebuildPipelinefunction and the./build/build-config.ymlconfiguration file are well-documented and thoroughly tested to prevent any build issues.Verification successful
The
./build/build-config.ymlconfiguration file exists and includes comments that outline its expected structure and provide examples, serving as a form of inline documentation. While there are no explicit mentions of "documentation" within the file, the initial comments offer guidance on configuring builds. It's still recommended to ensure thorough documentation and testing of thebuildPipelinefunction and the configuration file to prevent any build issues.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence and content of the build configuration file. cat ./build/build-config.yml # Ensure there's documentation or comments explaining the structure and expected values in the configuration file. grep -A5 -B5 "documentation" ./build/build-config.ymlLength of output: 667
build/maven/start.sh (1)
- 7-11: The script correctly sets default Java options and enables debugging based on an environment variable. Ensure that the application and environment are thoroughly tested with these settings, especially the dynamic assignment of the debug port.
| @@ -0,0 +1,9 @@ | |||
| FROM node:8.12-alpine | |||
There was a problem hiding this comment.
Using an older version of Node.js (node:8.12-alpine) might introduce security vulnerabilities and compatibility issues. Consider updating to a more recent LTS version of Node.js.
- FROM node:8.12-alpine
+ FROM node:16-alpineCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| FROM node:8.12-alpine | |
| FROM node:16-alpine |
| @@ -0,0 +1,9 @@ | |||
| FROM node:8.12-alpine | |||
| RUN npm install -g yarn | |||
There was a problem hiding this comment.
Installing Yarn globally as root can pose security risks. Consider using a non-root user for running the application and its dependencies.
+ RUN adduser -D appuser
+ USER appuserCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| RUN npm install -g yarn | |
| RUN adduser -D appuser | |
| USER appuser | |
| RUN npm install -g yarn |
| COPY package.json yarn.lock /opt/app/ | ||
| WORKDIR /opt/app | ||
| RUN yarn install | ||
| COPY . /opt/app |
There was a problem hiding this comment.
Ensure that only necessary files are copied to the Docker image to avoid bloating the image. Consider using a .dockerignore file to exclude unnecessary files.
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| if [[ -z "${JAVA_OPTS}" ]];then | |||
There was a problem hiding this comment.
The use of [[ for conditionals is not POSIX compliant, which might cause issues on systems not using bash as the default shell. Consider using POSIX-compliant syntax for broader compatibility.
- if [[ -z "${JAVA_OPTS}" ]];then
+ if [ -z "${JAVA_OPTS}" ]; thenCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if [[ -z "${JAVA_OPTS}" ]];then | |
| if [ -z "${JAVA_OPTS}" ]; then |
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (4)
configs/egov-searcher/rainmaker-pt-gissearch.yml (4)
57-79: Remove trailing spaces.There are trailing spaces in lines 61, 66, 67, and 75. These should be removed to adhere to coding standards.
- select + select - additionalDetail->>'mobileNo' as mobileNp + additionalDetail->>'mobileNo' as mobileNp - from eg_tl_tradelicense tl + from eg_tl_tradelicense tl - +Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
129-129: Remove trailing spaces.There are trailing spaces on line 129. These should be removed to adhere to coding standards.
- +Tools
yamllint
[error] 129-129: trailing spaces
(trailing-spaces)
136-158: Remove trailing spaces.There are trailing spaces on lines 140, 141, 153, and 158. These should be removed to adhere to coding standards.
- select array_to_json(array_agg(row_to_json(data))) from ( + select array_to_json(array_agg(row_to_json(data))) from ( - select id,tenantid,locality,issurveyidmandatory + select id,tenantid,locality,issurveyidmandatory - + - +Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
175-210: Remove trailing spaces.There are trailing spaces on lines 175, 176, and 210. These should be removed to adhere to coding standards.
- + - + - +Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (1)
configs/egov-searcher/rainmaker-pt-gissearch.yml (1)
33-48: Review the mandatory status ofpd.receiptdate.The
pd.receiptdateparameter has been changed from mandatory to optional. Ensure this change aligns with business requirements and doesn't affect downstream processes.
| - name: searchGisMap | ||
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from ( | ||
| with units as | ||
| ( | ||
| select | ||
| propertyuuid, | ||
| string_agg(occupancytype,',') as occupancy, | ||
| sum(builtuparea) as builtup_area | ||
| from report_units | ||
| where propertyuuid in (select pt_uuid from report_properties $where) | ||
| group by propertyuuid | ||
| ) | ||
| select | ||
| surveyid, | ||
| split_part(surveyid,'-',1) as town, | ||
| split_part(surveyid,'-',2) as sector, | ||
| split_part(surveyid,'-',3) as subsector, | ||
| 'plot' as plot, | ||
| rp.tenantid as city, | ||
| rp.propertyid as property_id, | ||
| oldpropertyid as oldpropertyid, | ||
| 'uidno' as uid_no, | ||
| 'blockcode' as wardno, | ||
| builtup_area as builtup_area, | ||
| plotsize as land_area, | ||
| 'area' as area, | ||
| nooffloors as no_of_floors, | ||
| propertyusagetype as usage_category, | ||
| occupancy as occupancy, | ||
| ownershipcategory as ownership_category, | ||
| assessmentyears as financial_year, | ||
| rpay.amoutpaid as amunt_paid, | ||
| rpay.receiptdate as date_of_payment | ||
| from report_properties rp | ||
| inner join units ru on rp.pt_uuid=ru.propertyuuid | ||
| inner join report_assessments ra on ra.propertyid=rp.propertyid | ||
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | ||
| $where) data | ||
| groupBy: | ||
| orderBy: | ||
| searchParams: | ||
| condition: AND | ||
| params: | ||
| - name: surveyid | ||
| isMandatory: true | ||
| jsonPath: $.searchCriteria.plot_map_id | ||
| operator: = | ||
|
|
||
| output: | ||
| jsonFormat: {"ResponseInfo": {}} | ||
| outJsonPath: $.data | ||
| responseInfoPath: $.ResponseInfo |
There was a problem hiding this comment.
Fix typo in rpay.amoutpaid.
There is a typo in the column name rpay.amoutpaid. It should be rpay.amountpaid.
- rpay.amoutpaid as amunt_paid,
+ rpay.amountpaid as amount_paid,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: searchGisMap | |
| query: | |
| baseQuery: | | |
| select array_to_json(array_agg(row_to_json(data))) from ( | |
| with units as | |
| ( | |
| select | |
| propertyuuid, | |
| string_agg(occupancytype,',') as occupancy, | |
| sum(builtuparea) as builtup_area | |
| from report_units | |
| where propertyuuid in (select pt_uuid from report_properties $where) | |
| group by propertyuuid | |
| ) | |
| select | |
| surveyid, | |
| split_part(surveyid,'-',1) as town, | |
| split_part(surveyid,'-',2) as sector, | |
| split_part(surveyid,'-',3) as subsector, | |
| 'plot' as plot, | |
| rp.tenantid as city, | |
| rp.propertyid as property_id, | |
| oldpropertyid as oldpropertyid, | |
| 'uidno' as uid_no, | |
| 'blockcode' as wardno, | |
| builtup_area as builtup_area, | |
| plotsize as land_area, | |
| 'area' as area, | |
| nooffloors as no_of_floors, | |
| propertyusagetype as usage_category, | |
| occupancy as occupancy, | |
| ownershipcategory as ownership_category, | |
| assessmentyears as financial_year, | |
| rpay.amoutpaid as amunt_paid, | |
| rpay.receiptdate as date_of_payment | |
| from report_properties rp | |
| inner join units ru on rp.pt_uuid=ru.propertyuuid | |
| inner join report_assessments ra on ra.propertyid=rp.propertyid | |
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | |
| $where) data | |
| groupBy: | |
| orderBy: | |
| searchParams: | |
| condition: AND | |
| params: | |
| - name: surveyid | |
| isMandatory: true | |
| jsonPath: $.searchCriteria.plot_map_id | |
| operator: = | |
| output: | |
| jsonFormat: {"ResponseInfo": {}} | |
| outJsonPath: $.data | |
| responseInfoPath: $.ResponseInfo | |
| rpay.amountpaid as amount_paid, |
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
| - name: IFMSintegration | ||
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from | ||
| (with details as | ||
| ( | ||
| SELECT pd.receiptnumber,payment.paidby,bill.consumercode,pd.amountpaid, | ||
| pd.businessservice, | ||
| pd.tenantid,payment.paymentmode,payment.transactionnumber as transactionNo ,t.mobile_number, taxheadcode , | ||
| SUM(adjustedamount) as amount FROM egcl_billaccountdetail as bad | ||
| INNER JOIN egcl_billdetial as bd on bd.id = bad.billdetailid | ||
| INNER JOIN egcl_bill bill on bd.billid = bill.id | ||
| INNER JOIN egcl_paymentdetail as pd on pd.billid = bd.billid | ||
| INNER JOIN egcl_payment as payment on pd.paymentid=payment.id | ||
| left outer join eg_pg_transactions t on t.bill_id=pd.billid | ||
| $where and payment.paymentstatus != 'CANCELLED' | ||
| GROUP BY pd.receiptnumber,pd.businessservice,pd.amountpaid,pd.tenantid, | ||
| payment.paymentmode,t.mobile_number,payment.transactionnumber, | ||
| bill.consumercode,payment.paidby,bad.taxheadcode | ||
| ) | ||
| select receiptnumber, | ||
| paidby, | ||
| consumercode, | ||
| amountpaid, | ||
| businessservice, | ||
| tenantid, | ||
| paymentmode, | ||
| transactionNo , | ||
| mobile_number, | ||
| json_agg( json_build_object('taxheadcode', taxheadcode,'amount', amount::text)) as taxheads , | ||
| ( case when consumercode like 'PT%' then (select usagecategory from eg_pt_property where propertyid=consumercode and status='ACTIVE') else '' end) as ptype | ||
| from details | ||
| group by receiptnumber,paidby, consumercode, amountpaid, businessservice, tenantid,paymentmode,transactionNo ,mobile_number | ||
| ) as data | ||
| groupBy: | ||
| orderBy: | ||
| searchParams: | ||
| condition: AND | ||
| params: | ||
| - name: pd.receiptdate | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.fromDate | ||
| operator: GE | ||
| - name: pd.receiptdate | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.toDate | ||
| operator: LE | ||
|
|
||
| output: | ||
| jsonFormat: {"ResponseInfo": {}} | ||
| outJsonPath: $.data | ||
| responseInfoPath: $.ResponseInfo | ||
|
|
There was a problem hiding this comment.
Fix typo in egcl_billdetial.
There is a typo in the table name egcl_billdetial. It should be egcl_billdetail.
- INNER JOIN egcl_billdetial as bd on bd.id = bad.billdetailid
+ INNER JOIN egcl_billdetail as bd on bd.id = bad.billdetailidCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: IFMSintegration | |
| query: | |
| baseQuery: | | |
| select array_to_json(array_agg(row_to_json(data))) from | |
| (with details as | |
| ( | |
| SELECT pd.receiptnumber,payment.paidby,bill.consumercode,pd.amountpaid, | |
| pd.businessservice, | |
| pd.tenantid,payment.paymentmode,payment.transactionnumber as transactionNo ,t.mobile_number, taxheadcode , | |
| SUM(adjustedamount) as amount FROM egcl_billaccountdetail as bad | |
| INNER JOIN egcl_billdetial as bd on bd.id = bad.billdetailid | |
| INNER JOIN egcl_bill bill on bd.billid = bill.id | |
| INNER JOIN egcl_paymentdetail as pd on pd.billid = bd.billid | |
| INNER JOIN egcl_payment as payment on pd.paymentid=payment.id | |
| left outer join eg_pg_transactions t on t.bill_id=pd.billid | |
| $where and payment.paymentstatus != 'CANCELLED' | |
| GROUP BY pd.receiptnumber,pd.businessservice,pd.amountpaid,pd.tenantid, | |
| payment.paymentmode,t.mobile_number,payment.transactionnumber, | |
| bill.consumercode,payment.paidby,bad.taxheadcode | |
| ) | |
| select receiptnumber, | |
| paidby, | |
| consumercode, | |
| amountpaid, | |
| businessservice, | |
| tenantid, | |
| paymentmode, | |
| transactionNo , | |
| mobile_number, | |
| json_agg( json_build_object('taxheadcode', taxheadcode,'amount', amount::text)) as taxheads , | |
| ( case when consumercode like 'PT%' then (select usagecategory from eg_pt_property where propertyid=consumercode and status='ACTIVE') else '' end) as ptype | |
| from details | |
| group by receiptnumber,paidby, consumercode, amountpaid, businessservice, tenantid,paymentmode,transactionNo ,mobile_number | |
| ) as data | |
| groupBy: | |
| orderBy: | |
| searchParams: | |
| condition: AND | |
| params: | |
| - name: pd.receiptdate | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.fromDate | |
| operator: GE | |
| - name: pd.receiptdate | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.toDate | |
| operator: LE | |
| output: | |
| jsonFormat: {"ResponseInfo": {}} | |
| outJsonPath: $.data | |
| responseInfoPath: $.ResponseInfo | |
| INNER JOIN egcl_billdetail as bd on bd.id = bad.billdetailid |
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
| concat(pt.propertyid , '/' , pt.surveyid) as primarykey, | ||
| pt.oldpropertyid as oldpropertyid, | ||
| pt.surveyid as surveyid, | ||
| pd.amountpaid as amount, | ||
| getfinancialyearforgis(pd.billid) as financialyear, | ||
| bn.blockname, | ||
| pt.tenantid as tenantid, | ||
| pd.receiptnumber as receiptnumber, | ||
| to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, | ||
| pt.landarea as plotarea |
There was a problem hiding this comment.
Ensure correct handling of null values in concatenation.
The concat(pt.propertyid , '/' , pt.surveyid) expression might result in unexpected values if pt.surveyid is null. Consider using COALESCE to handle null values.
- concat(pt.propertyid , '/' , pt.surveyid) as primarykey,
+ concat(pt.propertyid , '/' , COALESCE(pt.surveyid, '')) as primarykey,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| concat(pt.propertyid , '/' , pt.surveyid) as primarykey, | |
| pt.oldpropertyid as oldpropertyid, | |
| pt.surveyid as surveyid, | |
| pd.amountpaid as amount, | |
| getfinancialyearforgis(pd.billid) as financialyear, | |
| bn.blockname, | |
| pt.tenantid as tenantid, | |
| pd.receiptnumber as receiptnumber, | |
| to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, | |
| pt.landarea as plotarea | |
| concat(pt.propertyid , '/' , COALESCE(pt.surveyid, '')) as primarykey, | |
| pt.oldpropertyid as oldpropertyid, | |
| pt.surveyid as surveyid, | |
| pd.amountpaid as amount, | |
| getfinancialyearforgis(pd.billid) as financialyear, | |
| bn.blockname, | |
| pt.tenantid as tenantid, | |
| pd.receiptnumber as receiptnumber, | |
| to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, | |
| pt.landarea as plotarea |
Update integrated bills
There was a problem hiding this comment.
Actionable comments posted: 8
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/bill-genie.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/bill-genie.yml
[error] 9-9: trailing spaces
(trailing-spaces)
[warning] 10-10: too many spaces after colon
(colons)
[error] 10-10: trailing spaces
(trailing-spaces)
[error] 12-12: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 14-14: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 24-24: trailing spaces
(trailing-spaces)
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 30-30: trailing spaces
(trailing-spaces)
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
[error] 40-40: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
[error] 49-49: trailing spaces
(trailing-spaces)
[warning] 88-88: too few spaces after comma
(commas)
[error] 91-91: trailing spaces
(trailing-spaces)
[error] 96-96: trailing spaces
(trailing-spaces)
[warning] 97-97: too many spaces after colon
(colons)
[error] 97-97: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[error] 100-100: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
[error] 103-103: trailing spaces
(trailing-spaces)
[error] 104-104: trailing spaces
(trailing-spaces)
[error] 106-106: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 108-108: trailing spaces
(trailing-spaces)
[error] 109-109: trailing spaces
(trailing-spaces)
[error] 110-110: trailing spaces
(trailing-spaces)
[error] 111-111: trailing spaces
(trailing-spaces)
[error] 112-112: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 114-114: trailing spaces
(trailing-spaces)
[error] 116-116: trailing spaces
(trailing-spaces)
[error] 117-117: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 119-119: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
[error] 121-121: trailing spaces
(trailing-spaces)
[error] 123-123: trailing spaces
(trailing-spaces)
[error] 124-124: trailing spaces
(trailing-spaces)
[error] 125-125: trailing spaces
(trailing-spaces)
[error] 127-127: trailing spaces
(trailing-spaces)
[error] 131-131: trailing spaces
(trailing-spaces)
[error] 135-135: trailing spaces
(trailing-spaces)
[warning] 171-171: too few spaces after comma
(commas)
[warning] 177-177: too many blank lines
(4 > 2) (empty-lines)
[error] 181-181: trailing spaces
(trailing-spaces)
[warning] 182-182: too many spaces after colon
(colons)
[error] 182-182: trailing spaces
(trailing-spaces)
[error] 183-183: trailing spaces
(trailing-spaces)
[error] 184-184: trailing spaces
(trailing-spaces)
[error] 185-185: trailing spaces
(trailing-spaces)
[error] 186-186: trailing spaces
(trailing-spaces)
[error] 188-188: trailing spaces
(trailing-spaces)
[error] 189-189: trailing spaces
(trailing-spaces)
[error] 191-191: trailing spaces
(trailing-spaces)
[error] 192-192: trailing spaces
(trailing-spaces)
[error] 193-193: trailing spaces
(trailing-spaces)
[error] 194-194: trailing spaces
(trailing-spaces)
[error] 195-195: trailing spaces
(trailing-spaces)
[error] 196-196: trailing spaces
(trailing-spaces)
[error] 197-197: trailing spaces
(trailing-spaces)
[error] 198-198: trailing spaces
(trailing-spaces)
[error] 199-199: trailing spaces
(trailing-spaces)
[error] 201-201: trailing spaces
(trailing-spaces)
[error] 202-202: trailing spaces
(trailing-spaces)
[error] 203-203: trailing spaces
(trailing-spaces)
[error] 204-204: trailing spaces
(trailing-spaces)
[error] 205-205: trailing spaces
(trailing-spaces)
[error] 206-206: trailing spaces
(trailing-spaces)
[error] 208-208: trailing spaces
(trailing-spaces)
[error] 209-209: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
[error] 212-212: trailing spaces
(trailing-spaces)
[error] 216-216: trailing spaces
(trailing-spaces)
[error] 220-220: trailing spaces
(trailing-spaces)
[warning] 256-256: too few spaces after comma
(commas)
[error] 259-259: trailing spaces
(trailing-spaces)
[error] 263-263: trailing spaces
(trailing-spaces)
[warning] 264-264: too many spaces after colon
(colons)
[error] 264-264: trailing spaces
(trailing-spaces)
[error] 265-265: trailing spaces
(trailing-spaces)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 267-267: trailing spaces
(trailing-spaces)
[error] 268-268: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[error] 271-271: trailing spaces
(trailing-spaces)
[error] 273-273: trailing spaces
(trailing-spaces)
[error] 274-274: trailing spaces
(trailing-spaces)
[error] 275-275: trailing spaces
(trailing-spaces)
[error] 276-276: trailing spaces
(trailing-spaces)
[error] 277-277: trailing spaces
(trailing-spaces)
[error] 278-278: trailing spaces
(trailing-spaces)
[error] 279-279: trailing spaces
(trailing-spaces)
[error] 280-280: trailing spaces
(trailing-spaces)
[error] 281-281: trailing spaces
(trailing-spaces)
[error] 283-283: trailing spaces
(trailing-spaces)
[error] 284-284: trailing spaces
(trailing-spaces)
[error] 285-285: trailing spaces
(trailing-spaces)
[error] 286-286: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
[error] 288-288: trailing spaces
(trailing-spaces)
[error] 290-290: trailing spaces
(trailing-spaces)
[error] 291-291: trailing spaces
(trailing-spaces)
[error] 300-300: trailing spaces
(trailing-spaces)
[warning] 336-336: too few spaces after comma
(commas)
[error] 343-343: trailing spaces
(trailing-spaces)
[warning] 344-344: too many spaces after colon
(colons)
[error] 344-344: trailing spaces
(trailing-spaces)
[error] 345-345: trailing spaces
(trailing-spaces)
[error] 346-346: trailing spaces
(trailing-spaces)
[error] 347-347: trailing spaces
(trailing-spaces)
[error] 348-348: trailing spaces
(trailing-spaces)
[error] 350-350: trailing spaces
(trailing-spaces)
[error] 351-351: trailing spaces
(trailing-spaces)
[error] 353-353: trailing spaces
(trailing-spaces)
[error] 354-354: trailing spaces
(trailing-spaces)
[error] 355-355: trailing spaces
(trailing-spaces)
[error] 356-356: trailing spaces
(trailing-spaces)
[error] 357-357: trailing spaces
(trailing-spaces)
[error] 358-358: trailing spaces
(trailing-spaces)
[error] 359-359: trailing spaces
(trailing-spaces)
[error] 360-360: trailing spaces
(trailing-spaces)
[error] 361-361: trailing spaces
(trailing-spaces)
[error] 363-363: trailing spaces
(trailing-spaces)
[error] 364-364: trailing spaces
(trailing-spaces)
[error] 365-365: trailing spaces
(trailing-spaces)
[error] 366-366: trailing spaces
(trailing-spaces)
[error] 367-367: trailing spaces
(trailing-spaces)
[error] 368-368: trailing spaces
(trailing-spaces)
[error] 370-370: trailing spaces
(trailing-spaces)
[error] 371-371: trailing spaces
(trailing-spaces)
[error] 372-372: trailing spaces
(trailing-spaces)
[error] 378-378: trailing spaces
(trailing-spaces)
[error] 382-382: trailing spaces
(trailing-spaces)
[warning] 414-414: too few spaces after comma
(commas)
Additional comments not posted (2)
configs/egov-searcher/bill-genie.yml (2)
87-90: Remove trailing spaces.Trailing spaces should be removed from these lines for better readability and to avoid potential issues.
- output: + output: - jsonFormat: {"ResponseInfo": {},"Bills": []} + jsonFormat: {"ResponseInfo": {},"Bills": []} - outJsonPath: $.Bills + outJsonPath: $.Bills - responseInfoPath: $.ResponseInfo + responseInfoPath: $.ResponseInfoLikely invalid or redundant comment.
Tools
yamllint
[warning] 88-88: too few spaces after comma
(commas)
48-48: Remove trailing spaces.Trailing spaces should be removed from this line for better readability and to avoid potential issues.
- select * from bill_data inner join (select max(b_createddate) as maxcreateddate, bd_consumercode from bill_data group by bd_consumercode) as max ON max.maxcreateddate=b_createddate + select * from bill_data inner join (select max(b_createddate) as maxcreateddate, bd_consumercode from bill_data group by bd_consumercode) as max ON max.maxcreateddate=b_createddateLikely invalid or redundant comment.
| SELECT conn.status as conn_status,conn.property_id as pid,conn.oldConnectionNo as oldpid,conn.additionaldetails as conn_add,b.id AS b_id, b.mobilenumber, | ||
| b.tenantid AS b_tenantid, b.payername AS b_payername, | ||
| b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail, | ||
| b.isactive AS b_isactive, b.iscancelled AS b_iscancelled, | ||
| b.createdby AS b_createdby, b.status as b_status, b.filestoreid AS b_filestoreid, | ||
| b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby, | ||
| b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id, | ||
| bd.billid AS bd_billid, bd.tenantid AS bd_tenantid, | ||
| bd.businessservice AS bd_businessservice, bd.demandid, | ||
| bd.fromperiod, bd.toperiod, | ||
| bd.billno AS bd_billno, bd.billdate AS bd_billdate, | ||
| bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype, | ||
| bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage, | ||
| bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount, | ||
| bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate, | ||
| bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed, | ||
| bd.collectionmodesnotallowed AS bd_collectionmodesnotallowed, bd.createddate as bd_createddate, | ||
| b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails, | ||
| ad.id AS ad_id, ad.tenantid AS ad_tenantid, | ||
| ad.billdetail AS ad_billdetail, ad.glcode AS ad_glcode, | ||
| ad.orderno AS ad_orderno, ad.accountdescription AS ad_accountdescription, | ||
| ad.amount AS ad_amount, ad.adjustedamount AS ad_adjustedamount, | ||
| ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid, | ||
| ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose, | ||
| ad.additionaldetails as ad_additionaldetails, | ||
| ptadd.doorNo as ptadd_doorNo, ptadd.landmark as ptadd_landmark, | ||
| ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode, | ||
| ptadd.locality as ptadd_locality, ptown.userid as ptown_userid |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces should be removed from these lines for better readability and to avoid potential issues.
- SELECT conn.status as conn_status,conn.property_id as pid,conn.oldConnectionNo as oldpid,conn.additionaldetails as conn_add,b.id AS b_id, b.mobilenumber,
+ SELECT conn.status as conn_status, conn.property_id as pid, conn.oldConnectionNo as oldpid, conn.additionaldetails as conn_add, b.id AS b_id, b.mobilenumber,
- b.tenantid AS b_tenantid, b.payername AS b_payername,
+ b.tenantid AS b_tenantid, b.payername AS b_payername,
- b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail,
+ b.payeraddress AS b.payeraddress, b.payeremail AS b.payeremail,
- b.isactive AS b_isactive, b.iscancelled AS b_iscancelled,
+ b.isactive AS b_isactive, b.iscancelled AS b_iscancelled,
- b.createdby AS b_createdby, b.status as b_status, b.filestoreid AS b_filestoreid,
+ b.createdby AS b_createdby, b.status as b_status, b.filestoreid AS b_filestoreid,
- b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby,
+ b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby,
- b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id,
+ b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id,
- bd.billid AS bd_billid, bd.tenantid AS bd_tenantid,
+ bd.billid AS bd_billid, bd.tenantid AS bd_tenantid,
- bd.businessservice AS bd_businessservice, bd.demandid,
+ bd.businessservice AS bd_businessservice, bd.demandid,
- bd.fromperiod, bd.toperiod,
+ bd.fromperiod, bd.toperiod,
- bd.billno AS bd_billno, bd.billdate AS bd_billdate,
+ bd.billno AS bd_billno, bd.billdate AS bd_billdate,
- bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype,
+ bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype,
- bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage,
+ bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage,
- bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount,
+ bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount,
- bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate,
+ bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate,
- bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed,
+ bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed,
- bd.collectionmodesnotallowed AS bd_collectionmodesnotallowed, bd.createddate as bd_createddate,
+ bd.collectionmodesnotallowed AS bd.collectionmodesnotallowed, bd.createddate as bd.createddate,
- b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails,
+ b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails,
- ad.id AS ad_id, ad.tenantid AS ad_tenantid,
+ ad.id AS ad_id, ad.tenantid AS ad.tenantid,
- ad.billdetail AS ad_billdetail, ad.glcode AS ad_glcode,
+ ad.billdetail AS ad.billdetail, ad.glcode AS ad.glcode,
- ad.orderno AS ad_orderno, ad.account
<details>
<summary>Tools</summary>
<details>
<summary>yamllint</summary><blockquote>
[error] 98-98: trailing spaces
(trailing-spaces)
---
[error] 99-99: trailing spaces
(trailing-spaces)
---
[error] 100-100: trailing spaces
(trailing-spaces)
---
[error] 101-101: trailing spaces
(trailing-spaces)
---
[error] 103-103: trailing spaces
(trailing-spaces)
---
[error] 104-104: trailing spaces
(trailing-spaces)
---
[error] 106-106: trailing spaces
(trailing-spaces)
---
[error] 107-107: trailing spaces
(trailing-spaces)
---
[error] 108-108: trailing spaces
(trailing-spaces)
---
[error] 109-109: trailing spaces
(trailing-spaces)
---
[error] 110-110: trailing spaces
(trailing-spaces)
---
[error] 111-111: trailing spaces
(trailing-spaces)
---
[error] 112-112: trailing spaces
(trailing-spaces)
---
[error] 113-113: trailing spaces
(trailing-spaces)
---
[error] 114-114: trailing spaces
(trailing-spaces)
---
[error] 116-116: trailing spaces
(trailing-spaces)
---
[error] 117-117: trailing spaces
(trailing-spaces)
---
[error] 118-118: trailing spaces
(trailing-spaces)
---
[error] 119-119: trailing spaces
(trailing-spaces)
---
[error] 120-120: trailing spaces
(trailing-spaces)
---
[error] 121-121: trailing spaces
(trailing-spaces)
---
[error] 123-123: trailing spaces
(trailing-spaces)
---
[error] 124-124: trailing spaces
(trailing-spaces)
---
[error] 125-125: trailing spaces
(trailing-spaces)
</blockquote></details>
</details>
<!-- This is an auto-generated comment by CodeRabbit -->| - name: waterbills | ||
| isCustomerRowMapEnabled: true | ||
| rowMapperKey: billsearch | ||
| query: |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces can cause issues in YAML files and should be removed.
- query:
+ query:Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| query: | |
| query: |
Tools
yamllint
[error] 96-96: trailing spaces
(trailing-spaces)
| - name: billswithaddranduser | ||
| isCustomerRowMapEnabled: true | ||
| rowMapperKey: billsearch | ||
| query: |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces can cause issues in YAML files and should be removed.
- query:
+ query:Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| query: | |
| query: |
Tools
yamllint
[error] 9-9: trailing spaces
(trailing-spaces)
| isCustomerRowMapEnabled: true | ||
| rowMapperKey: billsearch | ||
| query: | ||
| baseQuery: with bill_data as ( |
There was a problem hiding this comment.
Remove trailing spaces and excessive spaces after colon.
Trailing spaces and excessive spaces after the colon should be removed for better readability and to avoid potential issues.
- baseQuery: with bill_data as (
+ baseQuery: with bill_data as (Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| baseQuery: with bill_data as ( | |
| baseQuery: with bill_data as ( |
Tools
yamllint
[warning] 10-10: too many spaces after colon
(colons)
[error] 10-10: trailing spaces
(trailing-spaces)
| isCustomerRowMapEnabled: true | ||
| rowMapperKey: billsearch | ||
| query: | ||
| baseQuery: with bill_data as ( |
There was a problem hiding this comment.
Remove trailing spaces and excessive spaces after colon.
Trailing spaces and excessive spaces after the colon should be removed for better readability and to avoid potential issues.
- baseQuery: with bill_data as (
+ baseQuery: with bill_data as (Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| baseQuery: with bill_data as ( | |
| baseQuery: with bill_data as ( |
Tools
yamllint
[warning] 97-97: too many spaces after colon
(colons)
[error] 97-97: trailing spaces
(trailing-spaces)
| FROM egbs_bill_v1 b INNER JOIN egbs_billdetail_v1 bd ON b.id = bd.billid AND b.tenantid = bd.tenantid | ||
| INNER JOIN egbs_billaccountdetail_v1 ad ON bd.id = ad.billdetail AND bd.tenantid = ad.tenantid | ||
| LEFT OUTER JOIN eg_pt_property pt ON bd.consumercode = pt.propertyid | ||
| INNER JOIN eg_pt_address ptadd ON ptadd.propertyid = pt.id | ||
| INNER JOIN eg_pt_asmt_assessment ptdet ON ptdet.propertyid = pt.propertyid | ||
| INNER JOIN eg_pt_owner ptown ON pt.id = ptown.propertyid $where ) |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces should be removed from these lines for better readability and to avoid potential issues.
- FROM egbs_bill_v1 b INNER JOIN egbs_billdetail_v1 bd ON b.id = bd.billid AND b.tenantid = bd.tenantid
+ FROM egbs_bill_v1 b INNER JOIN egbs_billdetail_v1 bd ON b.id = bd.billid AND b.tenantid = bd.tenantid
- INNER JOIN egbs_billaccountdetail_v1 ad ON bd.id = ad.billdetail AND bd.tenantid = ad.tenantid
+ INNER JOIN egbs_billaccountdetail_v1 ad ON bd.id = ad.billdetail AND bd.tenantid = ad.tenantid
- LEFT OUTER JOIN eg_pt_property pt ON bd.consumercode = pt.propertyid
+ LEFT OUTER JOIN eg_pt_property pt ON bd.consumercode = pt.propertyid
- INNER JOIN eg_pt_address ptadd ON ptadd.propertyid = pt.id
+ INNER JOIN eg_pt_address ptadd ON ptadd.propertyid = pt.id
- INNER JOIN eg_pt_asmt_assessment ptdet ON ptdet.propertyid = pt.propertyid
+ INNER JOIN eg_pt_asmt_assessment ptdet ON ptdet.propertyid = pt.propertyid
- INNER JOIN eg_pt_owner ptown ON pt.id = ptown.propertyid $where )
+ INNER JOIN eg_pt_owner ptown ON pt.id = ptown.propertyid $where)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| FROM egbs_bill_v1 b INNER JOIN egbs_billdetail_v1 bd ON b.id = bd.billid AND b.tenantid = bd.tenantid | |
| INNER JOIN egbs_billaccountdetail_v1 ad ON bd.id = ad.billdetail AND bd.tenantid = ad.tenantid | |
| LEFT OUTER JOIN eg_pt_property pt ON bd.consumercode = pt.propertyid | |
| INNER JOIN eg_pt_address ptadd ON ptadd.propertyid = pt.id | |
| INNER JOIN eg_pt_asmt_assessment ptdet ON ptdet.propertyid = pt.propertyid | |
| INNER JOIN eg_pt_owner ptown ON pt.id = ptown.propertyid $where ) | |
| FROM egbs_bill_v1 b INNER JOIN egbs_billdetail_v1 bd ON b.id = bd.billid AND b.tenantid = bd.tenantid | |
| INNER JOIN egbs_billaccountdetail_v1 ad ON bd.id = ad.billdetail AND bd.tenantid = ad.tenantid | |
| LEFT OUTER JOIN eg_pt_property pt ON bd.consumercode = pt.propertyid | |
| INNER JOIN eg_pt_address ptadd ON ptadd.propertyid = pt.id | |
| INNER JOIN eg_pt_asmt_assessment ptdet ON ptdet.propertyid = pt.propertyid | |
| INNER JOIN eg_pt_owner ptown ON pt.id = ptown.propertyid $where) |
Tools
yamllint
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
| searchParams: | ||
| condition: AND | ||
| params: | ||
| - name: b.tenantid | ||
| isMandatory: true | ||
| jsonPath: $.searchCriteria.tenantId | ||
| - name: bd.consumercode | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.consumerCode | ||
| operator: ILIKE | ||
| - name: bd.businessservice | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.businesService | ||
| - name: b.mobilenumber | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.mobileNumber | ||
| - name: bd.billno | ||
| isMandatory: false | ||
| operator: ILIKE | ||
| jsonPath: $.searchCriteria.billNo | ||
| - name: ptadd.locality | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.locality | ||
| - name: ptdet.financialyear | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.financialYear | ||
| - name: fromperiod | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.fromPeriod | ||
| operator: LE | ||
| - name: toperiod | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.toPeriod | ||
| operator: GE | ||
| - name: b.status | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.billActive | ||
|
|
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces should be removed from these lines for better readability and to avoid potential issues.
- searchParams:
+ searchParams:
- condition: AND
+ condition: AND
- params:
+ params:
- - name: b.tenantid
+ - name: b.tenantid
- isMandatory: true
+ isMandatory: true
- jsonPath: $.searchCriteria.tenantId
+ jsonPath: $.searchCriteria.tenantId
- - name: bd.consumercode
+ - name: bd.consumercode
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.consumerCode
+ jsonPath: $.searchCriteria.consumerCode
- operator: ILIKE
+ operator: ILIKE
- - name: bd.businessservice
+ - name: bd.businessservice
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.businesService
+ jsonPath: $.searchCriteria.businesService
- - name: b.mobilenumber
+ - name: b.mobilenumber
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.mobileNumber
+ jsonPath: $.searchCriteria.mobileNumber
- - name: bd.billno
+ - name: bd.billno
- isMandatory: false
+ isMandatory: false
- operator: ILIKE
+ operator: ILIKE
- jsonPath: $.searchCriteria.billNo
+ jsonPath: $.searchCriteria.billNo
- - name: ptadd.locality
+ - name: ptadd.locality
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.locality
+ jsonPath: $.searchCriteria.locality
- - name: ptdet.financialyear
+ - name: ptdet.financialyear
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.financialYear
+ jsonPath: $.searchCriteria.financialYear
- - name: fromperiod
+ - name: fromperiod
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.fromPeriod
+ jsonPath: $.searchCriteria.fromPeriod
- operator: LE
+ operator: LE
- - name: toperiod
+ - name: toperiod
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.toPeriod
+ jsonPath: $.searchCriteria.toPeriod
- operator: GE
+ operator: GE
- - name: b.status
+ - name: b.status
- isMandatory: false
+ isMandatory: false
- jsonPath: $.searchCriteria.billActive
+ jsonPath: $.searchCriteria.billActiveCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| searchParams: | |
| condition: AND | |
| params: | |
| - name: b.tenantid | |
| isMandatory: true | |
| jsonPath: $.searchCriteria.tenantId | |
| - name: bd.consumercode | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.consumerCode | |
| operator: ILIKE | |
| - name: bd.businessservice | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.businesService | |
| - name: b.mobilenumber | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.mobileNumber | |
| - name: bd.billno | |
| isMandatory: false | |
| operator: ILIKE | |
| jsonPath: $.searchCriteria.billNo | |
| - name: ptadd.locality | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.locality | |
| - name: ptdet.financialyear | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.financialYear | |
| - name: fromperiod | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.fromPeriod | |
| operator: LE | |
| - name: toperiod | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.toPeriod | |
| operator: GE | |
| - name: b.status | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.billActive | |
| searchParams: | |
| condition: AND | |
| params: | |
| - name: b.tenantid | |
| isMandatory: true | |
| jsonPath: $.searchCriteria.tenantId | |
| - name: bd.consumercode | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.consumerCode | |
| operator: ILIKE | |
| - name: bd.businessservice | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.businesService | |
| - name: b.mobilenumber | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.mobileNumber | |
| - name: bd.billno | |
| isMandatory: false | |
| operator: ILIKE | |
| jsonPath: $.searchCriteria.billNo | |
| - name: ptadd.locality | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.locality | |
| - name: ptdet.financialyear | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.financialYear | |
| - name: fromperiod | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.fromPeriod | |
| operator: LE | |
| - name: toperiod | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.toPeriod | |
| operator: GE | |
| - name: b.status | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.billActive |
Tools
yamllint
[error] 49-49: trailing spaces
(trailing-spaces)
| SELECT b.id AS b_id, b.mobilenumber, | ||
| b.tenantid AS b_tenantid, b.payername AS b_payername, | ||
| b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail, | ||
| b.isactive AS b_isactive, b.iscancelled AS b_iscancelled, | ||
| b.createdby AS b_createdby, b.status as b_status,b.filestoreid AS b_filestoreid, | ||
| b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby, | ||
| b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id, | ||
| bd.billid AS bd_billid, bd.tenantid AS bd_tenantid, | ||
| bd.businessservice AS bd_businessservice, bd.demandid, | ||
| bd.fromperiod, bd.toperiod, | ||
| bd.billno AS bd_billno, bd.billdate AS bd_billdate, | ||
| bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype, | ||
| bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage, | ||
| bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount, | ||
| bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate, | ||
| bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed, | ||
| bd.collectionmodesnotallowed AS bd_collectionmodesnotallowed, bd.createddate as bd_createddate, | ||
| b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails, | ||
| ad.id AS ad_id, ad.tenantid AS ad_tenantid, | ||
| ad.billdetail AS ad_billdetail, ad.glcode AS ad_glcode, | ||
| ad.orderno AS ad_orderno, ad.accountdescription AS ad_accountdescription, | ||
| ad.amount AS ad_amount, ad.adjustedamount AS ad_adjustedamount, | ||
| ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid, | ||
| ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose, | ||
| ad.additionaldetails as ad_additionaldetails, | ||
| ptadd.doorNo as ptadd_doorNo,ptadd.landmark as ptadd_landmark, | ||
| ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode, | ||
| ptadd.locality as ptadd_locality, ptown.userid as ptown_userid |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces should be removed from these lines for better readability and to avoid potential issues.
- SELECT b.id AS b_id, b.mobilenumber,
+ SELECT b.id AS b_id, b.mobilenumber,
- b.tenantid AS b_tenantid, b.payername AS b_payername,
+ b.tenantid AS b_tenantid, b.payername AS b_payername,
- b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail,
+ b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail,
- b.isactive AS b_isactive, b.iscancelled AS b_iscancelled,
+ b.isactive AS b_isactive, b.iscancelled AS b_iscancelled,
- b.createdby AS b_createdby, b.status as b_status,b.filestoreid AS b_filestoreid,
+ b.createdby AS b_createdby, b.status as b_status, b.filestoreid AS b_filestoreid,
- b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby,
+ b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby,
- b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id,
+ b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id,
- bd.billid AS bd_billid, bd.tenantid AS bd_tenantid,
+ bd.billid AS bd_billid, bd.tenantid AS bd_tenantid,
- bd.businessservice AS bd_businessservice, bd.demandid,
+ bd.businessservice AS bd_businessservice, bd.demandid,
- bd.fromperiod, bd.toperiod,
+ bd.fromperiod, bd.toperiod,
- bd.billno AS bd_billno, bd.billdate AS bd_billdate,
+ bd.billno AS bd_billno, bd.billdate AS bd_billdate,
- bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype,
+ bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype,
- bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage,
+ bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage,
- bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount,
+ bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount,
- bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate,
+ bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate,
- bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed,
+ bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed,
- bd.collectionmodesnotallowed AS bd_collectionmodesnotallowed, bd.createddate as bd_createddate,
+ bd.collectionmodesnotallowed AS bd.collectionmodesnotallowed, bd.createddate as bd_createddate,
- b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails,
+ b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails,
- ad.id AS ad_id, ad.tenantid AS ad_tenantid,
+ ad.id AS ad_id, ad.tenantid AS ad_tenantid,
- ad.billdetail AS ad_billdetail, ad.glcode AS ad_glcode,
+ ad.billdetail AS ad.billdetail, ad.glcode AS ad.glcode,
- ad.orderno AS ad_orderno, ad.accountdescription AS ad_accountdescription,
+ ad.orderno AS ad.orderno, ad.accountdescription AS ad.accountdescription,
- ad.amount AS ad_amount, ad.adjustedamount AS ad_adjustedamount,
+ ad.amount AS ad_amount, ad.adjustedamount AS ad.adjustedamount,
- ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid,
+ ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid,
- ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose,
+ ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose,
- ad.additionaldetails as ad_additionaldetails,
+ ad.additionaldetails as ad_additionaldetails,
- ptadd.doorNo as ptadd_doorNo,ptadd.landmark as ptadd_landmark,
+ ptadd.doorNo as ptadd_doorNo, ptadd.landmark as ptadd_landmark,
- ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode,
+ ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode,
- ptadd.locality as ptadd_locality, ptown.userid as ptown_userid
+ ptadd.locality as ptadd_locality, ptown.userid as ptown_useridCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| SELECT b.id AS b_id, b.mobilenumber, | |
| b.tenantid AS b_tenantid, b.payername AS b_payername, | |
| b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail, | |
| b.isactive AS b_isactive, b.iscancelled AS b_iscancelled, | |
| b.createdby AS b_createdby, b.status as b_status,b.filestoreid AS b_filestoreid, | |
| b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby, | |
| b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id, | |
| bd.billid AS bd_billid, bd.tenantid AS bd_tenantid, | |
| bd.businessservice AS bd_businessservice, bd.demandid, | |
| bd.fromperiod, bd.toperiod, | |
| bd.billno AS bd_billno, bd.billdate AS bd_billdate, | |
| bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype, | |
| bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage, | |
| bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount, | |
| bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate, | |
| bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed, | |
| bd.collectionmodesnotallowed AS bd_collectionmodesnotallowed, bd.createddate as bd_createddate, | |
| b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails, | |
| ad.id AS ad_id, ad.tenantid AS ad_tenantid, | |
| ad.billdetail AS ad_billdetail, ad.glcode AS ad_glcode, | |
| ad.orderno AS ad_orderno, ad.accountdescription AS ad_accountdescription, | |
| ad.amount AS ad_amount, ad.adjustedamount AS ad_adjustedamount, | |
| ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid, | |
| ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose, | |
| ad.additionaldetails as ad_additionaldetails, | |
| ptadd.doorNo as ptadd_doorNo,ptadd.landmark as ptadd_landmark, | |
| ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode, | |
| ptadd.locality as ptadd_locality, ptown.userid as ptown_userid | |
| SELECT b.id AS b_id, b.mobilenumber, | |
| b.tenantid AS b_tenantid, b.payername AS b_payername, | |
| b.payeraddress AS b_payeraddress, b.payeremail AS b_payeremail, | |
| b.isactive AS b_isactive, b.iscancelled AS b_iscancelled, | |
| b.createdby AS b_createdby, b.status as b_status, b.filestoreid AS b_filestoreid, | |
| b.createddate AS b_createddate, b.lastmodifiedby AS b_lastmodifiedby, | |
| b.lastmodifieddate AS b_lastmodifieddate, bd.id AS bd_id, | |
| bd.billid AS bd_billid, bd.tenantid AS bd_tenantid, | |
| bd.businessservice AS bd_businessservice, bd.demandid, | |
| bd.fromperiod, bd.toperiod, | |
| bd.billno AS bd_billno, bd.billdate AS bd_billdate, | |
| bd.consumercode AS bd_consumercode, bd.consumertype AS bd_consumertype, | |
| bd.billdescription AS bd_billdescription, bd.displaymessage AS bd_displaymessage, | |
| bd.minimumamount AS bd_minimumamount, bd.totalamount AS bd_totalamount, | |
| bd.callbackforapportioning AS bd_callbackforapportioning, bd.expirydate AS bd_expirydate, | |
| bd.partpaymentallowed AS bd_partpaymentallowed, bd.isadvanceallowed as bd_isadvanceallowed, | |
| bd.collectionmodesnotallowed AS bd.collectionmodesnotallowed, bd.createddate as bd_createddate, | |
| b.additionaldetails as b_additionaldetails, bd.additionaldetails as bd_additionaldetails, | |
| ad.id AS ad_id, ad.tenantid AS ad_tenantid, | |
| ad.billdetail AS ad.billdetail, ad.glcode AS ad.glcode, | |
| ad.orderno AS ad.orderno, ad.accountdescription AS ad.accountdescription, | |
| ad.amount AS ad_amount, ad.adjustedamount AS ad_adjustedamount, | |
| ad.taxheadcode AS ad_taxheadcode, ad.demanddetailid, | |
| ad.isactualdemand AS ad_isactualdemand, ad.purpose AS ad_purpose, | |
| ad.additionaldetails as ad_additionaldetails, | |
| ptadd.doorNo as ptadd_doorNo, ptadd.landmark as ptadd_landmark, | |
| ptadd.city as ptadd_city, ptadd.pincode as ptadd_pincode, | |
| ptadd.locality as ptadd_locality, ptown.userid as ptown_userid |
Tools
yamllint
[error] 12-12: trailing spaces
(trailing-spaces)
[error] 13-13: trailing spaces
(trailing-spaces)
[error] 14-14: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 24-24: trailing spaces
(trailing-spaces)
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 30-30: trailing spaces
(trailing-spaces)
[error] 31-31: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
Summary by CodeRabbit
New Features
searchTLApplicationsEODB,IFMSintegration,GetTenantConfig, andsearchGisMap.Chores
egov-dss-dashboards.