Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving inbox search composer #317

Merged
merged 22 commits into from
Apr 17, 2024
Merged

Conversation

nipunarora-eGov
Copy link
Contributor

@nipunarora-eGov nipunarora-eGov commented Apr 17, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced the useCustomMdms hook to support version 2 of MDMS API.
    • Updated pagination functionality in the ResultsTable component.
  • Documentation

    • Updated README files with the latest changes.
  • Chores

    • Updated package version to ensure consistency and fix versioning issues.

@nipunarora-eGov nipunarora-eGov requested a review from a team as a code owner April 17, 2024 09:48
Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

Walkthrough

This update focuses on enhancing the micro-ui project by improving the useCustomMdms hook to support a newer version of the MDMS API and updating the pagination functionality in the ResultsTable component across multiple beta versions.

Changes

File Path Change Summary
.../micro-ui-internals/packages/libraries/README.md Enhanced useCustomMdms hook for MDMS API v2; republished due to version issues; updated pagination.
.../micro-ui-internals/packages/react-components/... Updated pagination in ResultsTable component; incremented package version.

Possibly related issues

🐰✨🌟
A rabbit hopped through the code,
Tweaking hooks and loads,
With a jump and a skip, the pagination flipped,
Now smoother the data flows!
🌟✨🐇


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c507301 and 2697ccf.
Files selected for processing (3)
  • micro-ui/web/micro-ui-internals/packages/libraries/README.md (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/react-components/README.md (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/react-components/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • micro-ui/web/micro-ui-internals/packages/react-components/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagankumar-egov jagankumar-egov merged commit 0f5d855 into develop Apr 17, 2024
2 checks passed
@jagankumar-egov jagankumar-egov deleted the moving-inboxSearchComposer branch April 17, 2024 09:50
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Actionable comments outside the diff hunks (6)
micro-ui/web/micro-ui-internals/packages/libraries/README.md (3)

Line range hint 3-3: Capitalize the first letter of the heading for consistency and professionalism.

- # digit-ui-svg-components
+ # Digit-ui-svg-components

Line range hint 19-19: Consider adding a comma after "DIGIT-UI's" for grammatical correctness.

- This Package is more specific to DIGIT-UI's can be used across mission's
+ This Package is more specific to DIGIT-UI's, can be used across mission's

Line range hint 63-63: Avoid duplicating the phrase "DIGIT Frontend". It should be mentioned only once to maintain clarity.

- ### Published from DIGIT Frontend DIGIT Frontend Repo (https://github.com/egovernments/Digit-Frontend/tree/develop)
+ ### Published from DIGIT Frontend Repo (https://github.com/egovernments/Digit-Frontend/tree/develop)
micro-ui/web/micro-ui-internals/packages/react-components/README.md (3)

Line range hint 5-5: Capitalize the first letter of the heading for consistency and professionalism.

- # digit-ui-react-components
+ # Digit-ui-react-components

Line range hint 21-21: Consider adding a comma after "DIGIT-UI" for grammatical correctness.

- This package is specifically designed for DIGIT-UI but can be used across various missions.
+ This package is specifically designed for DIGIT-UI, but can be used across various missions.

Line range hint 186-186: Avoid duplicating the phrase "DIGIT Frontend". It should be mentioned only once to maintain clarity.

- ### Published from DIGIT Frontend DIGIT Frontend Repo (https://github.com/egovernments/Digit-Frontend/tree/develop)
+ ### Published from DIGIT Frontend Repo (https://github.com/egovernments/Digit-Frontend/tree/develop)

@@ -54,8 +54,7 @@ export default App;

### Changelog

```bash
1.8.1-beta.3: Updated code for pagination in ResultsTable component
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure there are no trailing spaces at the end of the line in the changelog for cleanliness and consistency in the markdown file.

- 1.8.1-beta.2: Enhanced `useCustomMdms` hook to support version 2 of MDMS API calls.
+ 1.8.1-beta.2: Enhanced `useCustomMdms` hook to support version 2 of MDMS API calls.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
```bash
```bash

</details>
<!-- suggestion_end -->

<!-- This is an auto-generated comment by CodeRabbit -->

@@ -137,6 +137,7 @@ To use the InboxSearchComposer component for managing multiple tabs, follow thes
### Changelog

```bash
1.8.1-beta.14 Updated code for pagination in ResultsTable component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure there are no trailing spaces at the end of the line in the changelog for cleanliness and consistency in the markdown file.

- 1.8.1-beta.14 Updated code for pagination in ResultsTable component
+ 1.8.1-beta.14 Updated code for pagination in ResultsTable component

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
1.8.1-beta.14 Updated code for pagination in ResultsTable component
1.8.1-beta.14 Updated code for pagination in ResultsTable component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants