fix #1611
fix #1611
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
⛔ Files ignored due to path filters (6)
micro-ui/web/core/package.jsonis excluded by!**/*.jsonmicro-ui/web/micro-ui-internals/example/package.jsonis excluded by!**/*.jsonmicro-ui/web/micro-ui-internals/packages/libraries/package.jsonis excluded by!**/*.jsonmicro-ui/web/package.jsonis excluded by!**/*.jsonmicro-ui/web/sandbox/package.jsonis excluded by!**/*.jsonmicro-ui/web/workbench/package.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
- micro-ui/web/micro-ui-internals/packages/libraries/src/utils/locale.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
micro-ui/web/micro-ui-internals/packages/libraries/src/utils/locale.js (1)
Pattern
**/*.js: check
| @@ -10,8 +10,21 @@ | |||
| */ | |||
|
|
|||
| export const getLocalityCode = (locality, tenantId) => { | |||
| if (typeof locality === "string") return locality.includes("_") ? locality : `${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality}`; | |||
| else if (locality.code) return locality.code.includes("_") ? locality : `${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality.code}`; | |||
| const isMultiRootTenant = Digit.Utils.getMultiRootTenant(); // Replace with your actual condition | |||
There was a problem hiding this comment.
Replace TODO comment with actual implementation.
The comment suggests replacing Digit.Utils.getMultiRootTenant() with the actual condition. Ensure this is implemented correctly.
Also, consider adding error handling for this call:
const isMultiRootTenant = Digit.Utils.getMultiRootTenant() ?? false; // Provide a default value| export const getLocalityCode = (locality, tenantId) => { | ||
| if (typeof locality === "string") return locality.includes("_") ? locality : `${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality}`; | ||
| else if (locality.code) return locality.code.includes("_") ? locality : `${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality.code}`; | ||
| const isMultiRootTenant = Digit.Utils.getMultiRootTenant(); // Replace with your actual condition | ||
|
|
||
| if (typeof locality === "string") { | ||
| return locality.includes("_") | ||
| ? locality | ||
| : isMultiRootTenant | ||
| ? `ADMIN_${locality}` | ||
| :`${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality}`; | ||
| } else if (locality.code) { | ||
| return locality.code.includes("_") | ||
| ? locality.code | ||
| : isMultiRootTenant | ||
| ? `ADMIN_${locality.code}` | ||
| :`${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality.code}`; | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Update function signature and add JSDoc.
The function now depends on Digit.Utils. Consider updating the function signature and adding JSDoc to reflect this change:
/**
* Get the locality code based on the input and tenant type.
* @param {string|Object} locality - The locality string or object with a code property.
* @param {string} tenantId - The tenant ID.
* @returns {string} The formatted locality code.
*/
export const getLocalityCode = (locality, tenantId) => {
// ... existing implementation
};
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- micro-ui/web/micro-ui-internals/packages/libraries/src/utils/locale.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
micro-ui/web/micro-ui-internals/packages/libraries/src/utils/locale.js (1)
Pattern
**/*.js: check
| else if (locality.code) return locality.code.includes("_") ? locality : `${tenantId.replace(".", "_").toUpperCase()}_ADMIN_${locality.code}`; | ||
| const isMultiRootTenant = Digit.Utils.getMultiRootTenant(); | ||
|
|
||
| if (typeof locality === "string") { |
There was a problem hiding this comment.
dont change in common method, it will be used outside pgr
so do it in pgr module code
Summary by CodeRabbit
New Features
Bug Fixes