Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto generate sidebar from header #226

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ittus
Copy link
Contributor

@ittus ittus commented May 13, 2019

Fix #186

When sidebar: 'auto', set sidebar to nav data

Screen Shot 2019-05-13 at 10 50 40

Update chinese doc
@egoist
Copy link
Owner

egoist commented May 13, 2019

It should use toc instead in auto mode

@ittus
Copy link
Contributor Author

ittus commented May 13, 2019

Do you mean it should get from '#', '##' ... tag?

@egoist
Copy link
Owner

egoist commented May 13, 2019

Yep. the same as VuePress.

@ittus
Copy link
Contributor Author

ittus commented May 13, 2019

Should the sidebar include toc of the current page, or it should include toc of all website?

Current page only:
Screen Shot 2019-05-13 at 13 50 13

@egoist
Copy link
Owner

egoist commented May 13, 2019

like VuePress, for current page only

@ittus ittus changed the title Auto generate sidebar from header feat: auto generate sidebar from header May 13, 2019
@ittus
Copy link
Contributor Author

ittus commented May 13, 2019

I've changed to
Screen Shot 2019-05-13 at 14 17 00

Please help to review the code when you're available.

@ittus
Copy link
Contributor Author

ittus commented Dec 10, 2019

@egoist Could you please help to review this pull request again? 🙇

@solider245
Copy link

@egoist能否请您再次审核此请求请求?🙇

你好,这个功能很好用,怎么我无法使用呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: use toc as sidebar
3 participants