Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make error - enhance portability #1674

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Aug 13, 2024

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Fix make error, see test case below (enhance portability)

Additional description (if needed):
Replaced u_int8_t with uint8_t, which is the way to go, its C99
Found on an older sun box

Test cases demonstrating functionality (if applicable):

$ make
[...]
inet_aton.c: In function `egg_inet_aton':
inet_aton.c:109: error: `u_int8_t' undeclared (first use in this function)
inet_aton.c:109: error: (Each undeclared identifier is reported only once
inet_aton.c:109: error: for each function it appears in.)
inet_aton.c:109: error: syntax error before "parts"
inet_aton.c:110: error: `pp' undeclared (first use in this function)
inet_aton.c:110: error: `parts' undeclared (first use in this function)
make[2]: *** [Makefile:40: inet_aton.o] Error 1
make[2]: Leaving directory '/export/home/michael/usr/src/eggdrop-1.10.0rc1/src/compat'
make[1]: *** [Makefile:74: compatibility] Error 2
make[1]: Leaving directory '/export/home/michael/usr/src/eggdrop-1.10.0rc1/src'
make: *** [Makefile:243: eggdrop] Error 2

Copy link
Member

@skralg skralg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vanosg vanosg added this to the v1.10.1 milestone Sep 3, 2024
@thommey
Copy link
Member

thommey commented Sep 8, 2024

needs to include stdint.h then?

@michaelortmann
Copy link
Member Author

michaelortmann commented Sep 9, 2024

stdint.h

no. none of our source files directly includes it, while some already use uint*_t

its defined / included via: inet_aton.c -> main.h -> eggint.h (created by configure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants