Skip to content

Commit

Permalink
Comment out new option in helm values, because it breaks the old vers…
Browse files Browse the repository at this point in the history
…ions of keda (the cmd arg does not exist for them), this way the default value is still correctly applied for new keda version because they have the fallback implemented also in the golang code (kedacore#659)

Signed-off-by: Jirka Kremser <[email protected]>
  • Loading branch information
jkremser authored Jul 2, 2024
1 parent 8a1ad4e commit 1286024
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion keda/templates/manager/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,11 @@ spec:
{{- if .Values.profiling.operator.enabled }}
- "--profiling-bind-address=:{{ .Values.profiling.operator.port }}"
{{- end }}
{{- range .Values.certificates.operator.caDirs }}
{{- with (.Values.certificates.operator).caDirs }}
{{- range . }}
- "--ca-dir={{ . }}"
{{- end }}
{{- end }}
{{- range $key, $value := .Values.extraArgs.keda }}
- "--{{ $key }}={{ $value }}"
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions keda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -817,8 +817,8 @@ certificates:
group: cert-manager.io
operator:
# -- Location(s) of CA files for authentication of external TLS connections such as TLS-enabled metrics sources
caDirs:
- /custom/ca
# caDirs:
# - /custom/ca

permissions:
metricServer:
Expand Down

0 comments on commit 1286024

Please sign in to comment.