Fix Odb.RemoveRoutingObstructions failing with non-integer coordinates #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we converting dbus to microns just to convert them back to DBUs? @kareefardi
|
add_obstructions:
remove_obstructions:
There is no redundancy here. The input should be in microns |
|
why not convert both to dbus and compare in integer space where things are more reliable? |
When specifying non integer coordinates in `ROUTING_OBSTRUCTIONS`, the Odb.RemoveRoutingObstructions would fail as it would truncate the decimal part before trying to match the coordinate.
For example, the following config would fail on any project (due to 16.5 appearing in the coordinate list):
```json
"ROUTING_OBSTRUCTIONS": [
"met1 10 10 20 16.5"
],
```
|
@kareefardi I updated the code to not use floats. Please review. |
kareefardi
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying non integer coordinates in
ROUTING_OBSTRUCTIONS, the Odb.RemoveRoutingObstructions would fail as it would truncate the decimal part before trying to match the coordinate.For example, the following config would fail on any project (due to 16.5 appearing in the coordinate list):