Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix facets display and handle full url facs #193

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Fix facets display and handle full url facs #193

merged 3 commits into from
Jul 16, 2023

Conversation

tuurma
Copy link
Member

@tuurma tuurma commented Jul 15, 2023

  • fix facets display for hierarchical facets (nested, multi-value)
  • add models for pb which produce pb-facs-link elements based on the value of @facs attribute
  • don't assume base-uri for pb-facsimile in the facsimile.html template
  • create a new template for Shakespeare example, which uses base-uri feature and prefixed pb/@facs approach

@tuurma
fix(facets): correct display for multi-valued nested hierarchical facets
4f176c6 
remove show all checkbox for facets where all available values are already visible
@tuurma
teipublisher.odd supports full url or iiif prefixed value for pb/@FACS …
39c51fa 
…and by default transforms these to pb-facs-links

adjust the default facsimile.html and create a special one for Shakespeare, defining base-uri for pb-facsimile
@tuurma
fix(template): point Shakespeare to its own html template
c27b6f7
@wolfgangmm wolfgangmm merged commit 5f317d0 into master Jul 16, 2023
2 checks passed
@tuurma tuurma deleted the fix-app-generation branch July 16, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuurma @wolfgangmm