Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve login and cookie handling #76

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve login and cookie handling #76

wants to merge 7 commits into from

Conversation

line-o
Copy link
Member

@line-o line-o commented Sep 22, 2024

FEATURES

  • allow and encourage custom login route handlers
    • read user name and login from any body or header content including XML bodies
  • allow and encourage custom logout route handlers
  • allows setting HttpOnly and SameSite attributes on login domain cookies (implementation in content/cookie.xqm)

FIXES

  • no redirect needed for logout, nor logout=true
  • do not attempt to login on every request
  • get rid of hard-coded field names user, password

@line-o
deps: update axios to 1.7.5
51bf051
@line-o
test: remove test from paths.test that is now part of auth.test
cee177c
@line-o
feat: improve cookie-login and -logout
30ef866 
- Use persistent login module directly to allow custom login and logout route handlers.
- Logout route does not need to redirect anymore.
- Add cookie.xqm utility module that is package private.
- Add custom login and logout route handlers to test app.
- Add and extend tests for login and logout.
@line-o
fix: raise specific error when route handler is not found
4eb8d57 
When a route tries to call a handler function that does not exist, roaster will return
with status code 500 and an actionable description:
"Operation not found for operationId:<operationId>"
@line-o
chore(test): fix formatting
c356cac
@line-o
build: use node v20
7f4dde5
@line-o
fix: cookie module must be exported
e15d551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrRataplan DrRataplan Awaiting requested review from DrRataplan

@duncdrum duncdrum Awaiting requested review from duncdrum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@line-o