Handle YAML replacement using SnakeYAML parsing/serialization instead of string manipulation. #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle YAML replacement using SnakeYAML parsing/serialization instead of string manipulation.
So I was thinking about the discussion on #22. I wondered if the issues around supporting multiple versions could be reduced by parsing the YAML and manipulating the parsed tree, rather than doing text replacement. This is the result.
I used SnakeYAML to parse
cassandra.yaml
and built a little object model (see here). It's backed by the generic SnakeYAML parse tree, with custom getters and setters for the values we want to change.The only existing API I couldn't support was withYamlReplacement. I could do something like
withYamlReplacement(String name, Object Value)
but it wouldn't be compatible with the existing API.