Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed event.keyCode to event.key or event.code #53

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Changed event.keyCode to event.key or event.code #53

merged 1 commit into from
Jan 3, 2025

Conversation

Kamieljv
Copy link
Contributor

@Kamieljv Kamieljv commented Jan 3, 2025

No description provided.

@Kamieljv Kamieljv linked an issue Jan 3, 2025 that may be closed by this pull request
event.keyCode is deprecated #51
Closed
@Kamieljv Kamieljv requested a review from anneb January 3, 2025 16:46
anneb
anneb approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@anneb anneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement

@anneb anneb merged commit 2092d53 into master Jan 3, 2025
@anneb anneb deleted the 51-eventkeycode-is-deprecated branch January 3, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneb anneb anneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event.keyCode is deprecated
2 participants
@Kamieljv @anneb