-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lexer / Function & Filter issues when using Twig2 #31
base: master
Are you sure you want to change the base?
Conversation
Twig2 requires that functions & global variables are added prior to the lexer being initialised, this fix allows us to use Twig2
Update Twiggy.php
Twig2 Calls functions and filters with different methods, added checks and updated function calls Tested with twig 2.4.3
…-updates Update Twiggy.php
Nice work, I'll adapt your work in my fork 😄, edmundask is no longer actively maintain this project. |
Cheers buddy, yeah I did tweet Ed a few weeks back as i've been putting off debugging and running through every line of code to see what the issues were with Twig v2. Are you maintaining this now? I shall bug ed again to transfer the repo to someone else or a group to maintain. I've got some more functionality to add for custom extensions etc etc |
I maintain not this repo sadly 😄 but i maintain my fork and adding new features to twiggy (like composer/non-composer support over config). It would be awesome if edmundask transfers the repo to someone else or create a group with a new/active group admin 😃 (A group without an active group admin is horrible). I'll test later your Twig v2 fix and then i merge it to my fork. You can create PR's on my fork too with new changes/enhancements^^ |
Sure ok,
I did checkout your fork and apply the edits, but couldn’t for some reason check them back in to a new branch.
I’ve never merged to forks of projects before, any help appreciated.
I will see if I can get hold of Ed and see if he can transfer it to us in order to maintain as it would be great to get some fixes into this as well as create some newer releases and stage twig 1 and twig 2 versions to save bloating the code.
Cheers
Steve
… On 4 Oct 2017, at 16:05, Raphael Jackstadt ***@***.***> wrote:
I maintain not this repo sadly 😄 but i maintain my fork and adding new features to twiggy (like composer/non-composer support over config).
You can look over my v1.0.0 issue here <REJack#3>.
It would be awesome if edmundask transfers the repo to someone else or create a group with a new/active group admin 😃 (A group without an active group admin is horrible).
I'll test later your Twig v2 fix and then i merge it to my fork. You can create PR's on my fork too with new changes/enhancements^^
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABwK3ZTtTL8yRl1L1rflQVOXKqdGLl3pks5so57WgaJpZM4Ps0jM>.
|
For this you need write access on my fork 😄, but you can go on my fork, and then click on "Fork" beside the count then you should create a fork from my fork, if this not works maybe you need to remove the other fork before you can create a new one. regards REJack |
Twig2 Fixes
Tested with twig 2.4.3
Please note
If you're using composer then you will need to comment out the following lines: