Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
edmont committed Dec 2, 2024
1 parent 98e8d56 commit cf26a72
Show file tree
Hide file tree
Showing 9 changed files with 214 additions and 314 deletions.
2 changes: 1 addition & 1 deletion include/openthread/thread.h
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,7 @@ uint32_t otThreadGetStoreFrameCounterAhead(otInstance *aInstance);
* @param[in] aWakeupIntervalUs An interval between consecutive wake-up frames (in microseconds).
* @param[in] aWakeupDurationMs Duration of the wake-up sequence (in milliseconds).
* @param[in] aCallback A pointer to function that is called when the wake-up succeeds or fails.
* @param[in] aCallbackContext A pointer to callback application-specific context.
* @param[in] aContext A pointer to callback application-specific context.
*
* @retval OT_ERROR_NONE Successfully started the wake-up.
* @retval OT_ERROR_INVALID_STATE Another attachment request is still in progress.
Expand Down
2 changes: 1 addition & 1 deletion src/core/mac/data_poll_handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ void DataPollHandler::HandleSentFrame(const Mac::TxFrame &aFrame, Error aError,
OT_ASSERT(false);
}

Get<IndirectSender>().HandleSentFrameToChild(aFrame, mFrameContext, aError, aChild);
Get<IndirectSender>().HandleSentFrameToCslNeighbor(aFrame, mFrameContext, aError, aChild);

exit:
return;
Expand Down
10 changes: 5 additions & 5 deletions src/core/mac/mac.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2488,15 +2488,15 @@ void Mac::ProcessCsl(const RxFrame &aFrame, const Address &aSrcAddr)
#endif

#if OPENTHREAD_CONFIG_WAKEUP_END_DEVICE_ENABLE
if (neighbor == nullptr)
{
neighbor = Get<Mle::Mle>().GetWakeupParent();
VerifyOrExit(neighbor->GetExtAddress() == aSrcAddr.GetExtended());
}
neighbor = neighbor == nullptr ? Get<Mle::Mle>().GetWakeupParent() : neighbor;
#endif

VerifyOrExit(neighbor != nullptr);

#if OPENTHREAD_CONFIG_WAKEUP_END_DEVICE_ENABLE
VerifyOrExit(neighbor->GetExtAddress() == aSrcAddr.GetExtended());
#endif

VerifyOrExit(csl->GetPeriod() >= kMinCslIePeriod);

neighbor->SetCslPeriod(csl->GetPeriod());
Expand Down
Loading

0 comments on commit cf26a72

Please sign in to comment.