Merge pull request #22 from edly-io/chore/remove_course_name_from_header

fix: remove course name from from header
edly-io · Oct 23, 2024 · 9559a85 · 9559a85
2 parents 17563db + b5501a9
commit 9559a85
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/src/Avatar.jsx b/src/Avatar.jsx
@@ -39,4 +39,5 @@ Avatar.defaultProps = {
   className: null,
 };
 
+
 export default Avatar;
diff --git a/src/learning-header/LearningHeader.jsx b/src/learning-header/LearningHeader.jsx
@@ -26,7 +26,7 @@ LinkedLogo.propTypes = {
 };
 
 const LearningHeader = ({
-  courseOrg, courseNumber, courseTitle, intl, showUserDropdown, userProfileImage,
+  courseTitle, intl, showUserDropdown, userProfileImage,
 }) => {
   const { authenticatedUser } = useContext(AppContext);
 
@@ -45,7 +45,6 @@ const LearningHeader = ({
       <div className="container-xl d-flex align-items-center">
         {headerLogo}
         <div className="flex-grow-1 course-title-lockup" style={{ lineHeight: 1 }}>
-          <span className="d-block small m-0">{courseOrg} {courseNumber}</span>
           <span className="d-block m-0 font-weight-bold course-title">{courseTitle}</span>
         </div>
         {showUserDropdown && authenticatedUser && (
@@ -63,17 +62,13 @@ const LearningHeader = ({
 };
 
 LearningHeader.propTypes = {
-  courseOrg: PropTypes.string,
-  courseNumber: PropTypes.string,
   courseTitle: PropTypes.string,
   userProfileImage: PropTypes.string,
   intl: intlShape.isRequired,
   showUserDropdown: PropTypes.bool,
 };
 
 LearningHeader.defaultProps = {
-  courseOrg: null,
-  courseNumber: null,
   courseTitle: null,
   userProfileImage: null,
   showUserDropdown: true,

diff --git a/src/learning-header/LearningHeader.test.jsx b/src/learning-header/LearningHeader.test.jsx
@@ -17,13 +17,10 @@ describe('Header', () => {
 
   it('displays course data', () => {
     const courseData = {
-      courseOrg: 'course-org',
-      courseNumber: 'course-number',
       courseTitle: 'course-title',
     };
     render(<Header {...courseData} />);
 
-    expect(screen.getByText(`${courseData.courseOrg} ${courseData.courseNumber}`)).toBeInTheDocument();
     expect(screen.getByText(courseData.courseTitle)).toBeInTheDocument();
   });
 });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,4 +39,5 @@ Avatar.defaultProps = {
		className: null,
		};


Check failure on line 42 in src/Avatar.jsx View workflow job for this annotation GitHub Actions / Release `More than 1 blank line not allowed`
		export default Avatar;