Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix (tabulator): caret saving works unexpectedly in safare #86

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Bugfix (tabulator): caret saving works unexpectedly in safare #86

merged 10 commits into from
Oct 9, 2024

Conversation

e11sy
Copy link

@e11sy e11sy commented Oct 7, 2024

Problem

In safari after saving and restoring caret with

restore = save()

restore()

exception raises on the following action

Solution

Refactored list tabulator for it not to use saving and restoring caret
Now we use focusItem() method instead

@e11sy e11sy changed the base branch from eslint-fixes to release/2.0 October 7, 2024 18:39
@e11sy e11sy merged commit 73dead0 into release/2.0 Oct 9, 2024
1 check passed
@neSpecc neSpecc deleted the safari-restore-caret-bigfix branch October 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e11sy @neSpecc