Feature/disable tool elements #122
Open
+89
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
requested changes
Dec 5, 2024
src/index.ts
Outdated
| @@ -75,6 +75,10 @@ export default class EditorjsList { | |||
| }, | |||
| }, | |||
| ]; | |||
|
|
|||
| return this.displayedEntries ? entries.filter( | |||
| ele => this.displayedEntries?.includes(ele.data.style as ListDataStyle) | |||
src/index.ts
Outdated
Comment on lines
178
to
181
| /** | ||
| * | ||
| */ | ||
| private static displayedEntries?: ListDataStyle[]; |
src/index.ts
Outdated
Comment on lines
316
to
318
| if (EditorjsList.displayedEntries){ | ||
| if (this.listStyle === 'ordered') this.addAdditionalTunes(defaultTunes); | ||
| } else if (this.listStyle === 'ordered') this.addAdditionalTunes(defaultTunes); |
There was a problem hiding this comment.
no need to check for EditorjsList.displayedEntries here
src/index.ts
Outdated
| @@ -75,6 +75,10 @@ export default class EditorjsList { | |||
| }, | |||
| }, | |||
| ]; | |||
|
|
|||
| return this.displayedEntries ? entries.filter( | |||
There was a problem hiding this comment.
you cannot access this.displayedEntries since it is static
src/index.ts
Outdated
Comment on lines
321
to
327
| tune => { | ||
| if ('title' in tune) { | ||
| if(tune.title === 'Start with' || tune.title === 'Counter type') return true; | ||
| else return EditorjsList.displayedEntries?.includes(tune.title!.toLowerCase() as ListDataStyle); | ||
| } else if (('type' in tune) && tune.type === 'separator') return true; | ||
| } | ||
| ) : defaultTunes; |
There was a problem hiding this comment.
you can firstly filter default tunes, and then add additional ones, then you won't need to check for Start with and Counter type in tunes
neSpecc
reviewed
Dec 5, 2024
README.md
Outdated
| @@ -64,6 +64,7 @@ var editor = EditorJS({ | |||
| |--------------|----------|----------------------------------------------------------------| | |||
| | defaultStyle | `string` | default list style: `ordered`, `unordered` or `checklist`, default is `unordered` | | |||
| | maxLevel | `number` | maximum level of the list nesting, could be set to `1` to disable nesting, unlimited by default | | |||
| | displayedEntries | `listStyle[]` | List entries allowed to be displayed `ordered`, `unordered` or `checklist` | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119