fix: make sure html element attributes are set

editor-js · Jul 28, 2024 · 449be27 · 449be27
1 parent 6f8acd8
commit 449be27
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/utils/dom.ts b/src/utils/dom.ts
@@ -24,11 +24,10 @@ export function make(
     el.classList.add(classNames);
   }
 
-  if (attributes) {
-    Object.entries(attributes).forEach(([key, value]) => {
-      if (!value) return;
-      el.setAttribute(key, value.toString());
-    });
+  for (const attrName in attributes) {
+    // as any is used to avoid TS error that read-only properties of HTMLElement are not assignable
+    (el[attrName as keyof HtmlElementAttributes] as any) =
+      attributes[attrName as keyof HtmlElementAttributes];
   }
 
   return el;