Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instagram reels and post regex fixed #125

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Instagram reels and post regex fixed #125

merged 7 commits into from
Oct 11, 2024

Conversation

Abhii5496
Copy link
Contributor

@Abhii5496 Abhii5496 commented Apr 8, 2024 •
edited
Loading

Previously it was not Recognising the instagram post and reel urls .
Modification in regex of instagram , now it will render post and reel both without any issue,

neSpecc
neSpecc requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove unrelated changes.
Describe issues you're resolving in a PR description.
Give a few URL to check

@Abhii5496
Copy link
Contributor Author

Please, remove unrelated changes. Describe issues you're resolving in a PR description. Give a few URL to check

sure

@Abhii5496
Copy link
Contributor Author

i have removed the unrelated changes and added description
here are some urls to check ::
https://www.instagram.com/p/C4_Lsf1NBra/?img_index=1
https://www.instagram.com/p/C5ZZUWPydSY/?utm_source=ig_web_copy_link
https://www.instagram.com/reel/C19IuqJx6wm/
https://www.instagram.com/reel/C19IuqJx6wm/?utm_source=ig_web_copy_link

neSpecc
neSpecc requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add corresponded tests and update a patch version

@Abhii5496
Copy link
Contributor Author

Abhii5496 commented Apr 13, 2024 •
edited
Loading

Please add corresponded tests and update a patch version

added the test , @neSpecc can you please check ,

@Abhii5496 Abhii5496 requested a review from neSpecc May 2, 2024 06:14
neSpecc
neSpecc reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update a patch version please

@Abhii5496
Copy link
Contributor Author

@neSpecc , updated it .

@Abhii5496 Abhii5496 requested a review from neSpecc June 3, 2024 04:46
@neSpecc
Copy link
Contributor

neSpecc commented Jul 1, 2024

Resolve conflicts, please

@Abhii5496 Abhii5496 requested a review from neSpecc October 9, 2024 07:34
@Abhii5496
Copy link
Contributor Author

@neSpecc conflict resolved , merge it.

neSpecc
neSpecc reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increment a patch version please

@neSpecc neSpecc merged commit 747f9e7 into editor-js:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhii5496 @neSpecc