feat(playground): document tree rendering #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 579/579 |
| 🟢 | Branches | 99.26% | 135/136 |
| 🟢 | Functions | 99.32% (+0.01% 🔼) |
145/146 |
| 🟢 | Lines | 100% | 555/555 |
Test suite run success
338 tests passing in 18 suites.
Report generated by 🧪jest coverage report action from 8ad3a1f
✅ Mutation testing passedReport: https://dashboard.stryker-mutator.io/reports/github.com/editor-js/document-model/PR-52 Mutated filessrc/utils/DeepReadonly.ts |
gohabereg
reviewed
Nov 15, 2023
| /** | ||
| * Allows accessing Block data | ||
| */ | ||
| public get data(): BlockNodeData { |
There was a problem hiding this comment.
We should make the return type readonly (would be nice to check if it works for nested structures as well)
| /** | ||
| * Returns the data associated with this value node. | ||
| */ | ||
| public get value(): ValueType { |
There was a problem hiding this comment.
Also should be readonly as it could be array/object
| * | ||
| * @param value - The value to check | ||
| */ | ||
| function isObject(value: unknown): value is object { |
There was a problem hiding this comment.
Could be extracted to a separate function
gohabereg
reviewed
Nov 15, 2023
| */ | ||
| export type DeepReadonly<T> = | ||
| T extends (infer R)[] ? DeepReadonlyArray<R> : | ||
| // eslint-disable-next-line @typescript-eslint/ban-types |
There was a problem hiding this comment.
You can remove this if you use (...args: unknown[]) => unknown instead of Function
Comment on lines
33
to
38
| return Object.entries(descriptors).filter(([name, descriptor]) => { | ||
| return descriptor.get !== undefined; | ||
| }) | ||
| .map(([ name ]) => { | ||
| return name as keyof typeof props.node; | ||
| }); |
There was a problem hiding this comment.
Looks like some formatting could be applied here
gohabereg
approved these changes
Nov 15, 2023
ilyamore88
approved these changes
Nov 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have a base Editor Document tree rendering