feat(event-bus): implement simple eventbus class #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Mutation testing passedReport: https://dashboard.stryker-mutator.io/reports/github.com/editor-js/document-model/PR-43 Mutated filessrc/utils/EventBus/EventBus.ts |
Coverage report
Test suite run success311 tests passing in 18 suites. Report generated by 🧪jest coverage report action from 033165d |
gohabereg
approved these changes
Nov 9, 2023
neSpecc
reviewed
Nov 10, 2023
src/utils/EventBus/EventBus.ts
Outdated
| @@ -0,0 +1,64 @@ | |||
| import EventEmitter from 'eventemitter3'; | |||
There was a problem hiding this comment.
why not to use native EventTarget?
There was a problem hiding this comment.
70+ kb is too much for such a simple thing, I guess.
There was a problem hiding this comment.
Replaced with EventTarget
gohabereg
reviewed
Nov 13, 2023
| /** | ||
| * The document model has been changed | ||
| */ | ||
| CHANGED = 'changed', |
gohabereg
approved these changes
Nov 13, 2023
neSpecc
approved these changes
Nov 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #22
Changelog
ToDo