Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ability to install packages from npm, using cdn by default #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removed ability to install packages from npm, using cdn by default #9

wants to merge 5 commits into from

Conversation

slaveeks
Copy link
Contributor

@slaveeks slaveeks commented May 5, 2023 •
edited
Loading

  1. Removed installing packages, using CDN skypack by default
  2. Changed path for saving esm bundles
  3. Added ability to use not default CDN
  4. Added support if named exports of tools
  5. Now to run dev-stand, you need to run one dev-stand script

neSpecc
neSpecc reviewed May 5, 2023
View reviewed changes
setup/Stand/Stand.ts
*/
this.addScript(plugin.path, false);
} else {
const toolClassName = `Tool${index}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems hardcoded. If it is internal key, move it to a separate method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc left review comments

@talyguryn talyguryn Awaiting requested review from talyguryn

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaveeks @neSpecc