Add support for notifications API #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that notifications is not covered in this library so I've added functions cover this part of API.
I've also tried to add tests to every new function but in seems that token used in tests has not access to notifications, or I'm doing something wrong. Also I've tried to test
Notifications.Threadmodule but I have no idea how to test. It requirethread_idbut I have no idea how to find one valid. The one used in docs is some random and official documentation uses1as id which returns that I have no access to this repository.I'm novice to elixir so if someone can review this or improve my additions it would be awesome.