Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rework e2e tests #910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: rework e2e tests #910

wants to merge 1 commit into from

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Oct 4, 2024

This achieves the following goals:

  1. Only run the openssl tests for PRs.
  2. Only run the servicemesh tests when its files have been touched.
  3. Run all other tests every day at night (and send notifications on failure).
  4. Keep the manual dispatch workflow.

I don't think it's possible to reasonably achieve all of those with a single workflow file (though I'm open to suggestions), so I've turned e2e.yaml into a reusable workflow that's invoked by other workflow files with different parameters.

@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Oct 4, 2024
@Freax13 Freax13 force-pushed the tom/ci-rework branch 12 times, most recently from 74cf071 to 76fa38e Compare October 4, 2024 12:22
This achieves the following goals:
1. Only run the openssl tests for PRs.
2. Only run the servicemesh tests when its files have been touched.
3. Run all other tests every day at night (and send notifications on
   failure).
4. Keep the manual dispatch workflow.

I don't think it's possible to reasonably achieve all of those with a
single workflow file, so I've turned e2e.yaml into a reusable workflow
that's invoked by other workflow files with different parameters.
@Freax13 Freax13 changed the title WIP ci: rework e2e tests Oct 4, 2024
@Freax13 Freax13 marked this pull request as ready for review October 4, 2024 14:30
@Freax13 Freax13 requested a review from burgerdev October 4, 2024 14:30
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Comment on lines +11 to +15
- openssl
- servicemesh
- policy
- workloadsecret
- volumestatefulset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- openssl
- servicemesh
- policy
- workloadsecret
- volumestatefulset
- genpolicy
- getdents
- openssl
- policy
- regression
- servicemesh
- volumestatefulset
- workloadsecret

I think we should be able to run the regression tests manually with this, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants