Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: run regression tests on bare metal #907

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

Ensure that known test cases work, regardless of platform, and fix a couple of issues for the tests to succeeded:

MongoDB

  • The size limit of the database volume was too small and led to pod eviction.
  • The image is 1.2GiB, too large for the default memory limits when using guest pull.

MySQL

The MySQL images need additional configuration to run, otherwise they end up crash-looping and cause sporadic errors.

Varnish

The Varnish we're using is a source-to-image image which does not actually run a server in the default configuration. Since I don't know how we would want to configure Varnish in the first place, I'm removing the image. cc @miampf

Image build

The CONFIDENTIAL_GUEST environment variable for the rootfs build is set upstream when COCO guest components are provided. Since we don't provide them, we need to set it manually so that we get the features enabled by it.

For now, the only feature guarded by this variable is an increased /run mount size. However, there seems to be a bug in the implementation, because the systemd target that's edited is not yet in the new root, so systemd-remount-fs is not enabled and thus modifying fstab has no effect. We work around this by adding the targets before the rootfs build and disabling a cleanup step in the build script.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Oct 2, 2024
@burgerdev burgerdev requested a review from miampf October 2, 2024 11:36
@burgerdev burgerdev requested a review from Freax13 October 2, 2024 12:33
Comment on lines +48 to +49
- platform:
self-hosted: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this works, I always assumed it wouldn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the partial matching of objects? I did not know either - could be better documented, I guess.

Copy link
Contributor

@miampf miampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@burgerdev burgerdev merged commit b029db3 into main Oct 4, 2024
26 checks passed
@burgerdev burgerdev deleted the burgerdev/regression branch October 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants